New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(smart-contracts): deploy and verify batch contract #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivier7delf
force-pushed
the
fix/smart-contract/deploy-batch
branch
from
June 23, 2022 16:54
72fe592
to
454a41a
Compare
olivier7delf
changed the title
Fix/smart contract/deploy batch
fix(batch): fix - deploy and verify batch
Jun 23, 2022
github-actions
bot
requested review from
benjlevesque,
bertux,
kevindavee and
yomarion
June 24, 2022 07:39
olivier7delf
requested review from
alexandre-abrioux,
leoslr and
KolevDarko
and removed request for
benjlevesque and
kevindavee
June 24, 2022 07:39
bertux
approved these changes
Jun 24, 2022
packages/smart-contracts/scripts-create2/contract-setup/setupBatchPayments.ts
Outdated
Show resolved
Hide resolved
packages/smart-contracts/scripts-create2/contract-setup/setupBatchPayments.ts
Outdated
Show resolved
Hide resolved
bertux
suggested changes
Jun 24, 2022
…atchPayments.ts Co-authored-by: Bertrand Juglas <b@juglas.name>
Co-authored-by: Bertrand Juglas <b@juglas.name>
…atchPayments.ts Co-authored-by: Bertrand Juglas <b@juglas.name>
bertux
approved these changes
Jun 24, 2022
olivier7delf
changed the title
fix(batch): fix - deploy and verify batch
fix(batch): deploy and verify batch proxies
Jun 24, 2022
olivier7delf
changed the title
fix(batch): deploy and verify batch proxies
fix(smart-contracts): batch deploy and verify batch proxies
Jun 24, 2022
olivier7delf
changed the title
fix(smart-contracts): batch deploy and verify batch proxies
fix(smart-contracts): batch deploy and verify proxies
Jun 24, 2022
olivier7delf
changed the title
fix(smart-contracts): batch deploy and verify proxies
fix(smart-contracts): deploy and verify batch contract
Jun 24, 2022
yomarion
approved these changes
Jun 24, 2022
packages/smart-contracts/scripts-create2/contract-setup/adminTasks.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batch contracts deployed and verified: bsc, avalanche, and Rinkeby (address updated)
Fix setup batch deployment
Fix gnosis WEB3_PROVIDER_URL
Refacto networkRPC utils