Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding tNEAR for near-testnet #958

Merged
merged 1 commit into from Oct 17, 2022
Merged

Conversation

bertux
Copy link
Contributor

@bertux bertux commented Oct 14, 2022

Description of the changes

need new native token declared on new chain to be able to test the integration in currency-api and then from end to end

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.098% when pulling c9a977f on chore/near-testnet-token into fa4617a on master.

Copy link
Member

@alexandre-abrioux alexandre-abrioux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the need to rename this, what's wrong with NEAR-testnet? I can't find any documentation on the tNEAR symbol online, that's why I'm asking this.

packages/currency/src/native.ts Show resolved Hide resolved
@KolevDarko
Copy link
Contributor

@bertux are we actualy adding a made-up token tNear just for testing ?

Copy link
Member

@alexandre-abrioux alexandre-abrioux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw in DM: it's to remove confusion between the new near-testnet chain (renamed from aurora-testnet) and the NEAR-testnet currency.

@bertux bertux merged commit db3138d into master Oct 17, 2022
@bertux bertux deleted the chore/near-testnet-token branch October 17, 2022 08:41
@bertux
Copy link
Contributor Author

bertux commented Oct 21, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants