Removal of Unused Functions

[msxfm]

Issue by jsamuel
Thursday Dec 22, 2011 at 19:01 GMT
Originally opened as RequestPolicy/requestpolicy#233

---

imported trac ticket
created: 2011-06-17 23:11:40
reporter: eibwen

There appear to be at least 12 (!) functions that are not currently used. Recommend removal of these functions:

''./src/components/requestpolicyService.js''

  _combinedOriginToDestinationIdentifierHasOrigin
  _combinedOriginToDestinationIdentifierHasDestination
  _dumpRejectedRequests
  _dumpAllowedRequests

''./src/content/menu.js''

  _removeExtraSubmenuSeparators
  _disableMenuIfEmpty

''./src/content/overlay.js''

  _contextMenuOnPopupHidden
  _performRedirect

''./src/modules/DomainUtil.jsm:''

  identifierIsInUri
  stripWww
  sameHostIgnoreWww
  destinationIsSubdomainOfOrigin

Note that there are additional functions that are not referenced in the extension; however, they are implied to be required by the IDL of an XPCOM component/observer or similar.

[msxfm]

Comment by jsamuel
Thursday Dec 22, 2011 at 19:01 GMT

---

imported trac comment
created: 2011-06-18 15:08:50
author: eibwen

More unused functions:

''./src/components/requestpolicyService.js''

  _printAllowedRequests
  _printRejectedRequests
  _dumpRequestTrackingObject

Running total: '''15''' unused functions!
Granted, the last one was used, but only by functions that were themselves unused...

[myrdd]

Functions still existing and still unused:

in ''./src/content/overlay.js'':
    _contextMenuOnPopupHidden

in ''./src/modules/DomainUtil.jsm":
    identifierIsInUri
    stripWww
    sameHostIgnoreWww
    destinationIsSubdomainOfOrigin

in ''./src/modules/RequestProcessor.jsm'':
    _printAllowedRequests
    _printRejectedRequests

imho those functions can be removed without any problem, they are obsolete.

[myrdd]

cb7367d