-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0 has no menu entry in the context menu (right-click menu) #353
Comments
Comment by Jookia I'd like this too, as all my other add-ons do this. |
I'd like to implement this for version 1.0 |
@myrdd I, for one, prefer the new menu. Colors make it more understandable, the blocked/allowed sections make it clear what's blocked/allowed with a quick look... The old menu was nice but you have to navigate it a bit to know about blocked requests. Some menu entries (prefs, request log) are not frequently used, so having them in light gray, small font makes sense (in the old menu they "clutter up" the interface a bit). What advantages do you see in reverting to the old menu? It's great to have an option for it but RP should default to the new menu IMHO. |
Good question. In fact my main idea was to have a menu which is as simple as possible. I had a discussion with some friends about the menu design mainly regarding the "complexity". We compared the menu to that of NoScript and recognized that NoScript is easier to handle with because you only have one domain, not two (origin/dest). We concluded that most users probably only want to say "I trust that domain" instead of "I trust this domain, but only from the current domain". As I can now see, you prefer the new menu, so the default menu is still to be discussed. Having the old menu in newer versions creates some kind of backwards compatibility of the design. In addition, the "classic" style is somewhat known from many other menus (e.g. context menu, …). However, a "simple menu" which displays only the destinations (origin is always
font colors are possible (but maybe not advisable).
I see two possibilities
that's right. but noscript also has some seldom used menu entries on the top. we could position them on the bottom. So what should we do? More opinions are very welcome! |
I'm adding my own voice to the request to keep the old UI from the 0.5.x series. It's very detailed. It works. It follows the same UI style as NoScript and CookieMonster, which when combined with RequestPolicy, serve as a very fine-grained control over how the browser handles scripts, requests generated from those scripts, and cookies. The newer interface feels entirely too minimal to me. I know the trend is to simplify everything to death and remove "buttons only used X% of the time," but I don't think the userbase of theses types of add-ons would benefit from that approach. |
Thanks for your opinion @aggroskater. So we will have the old menu still in 1.0. I'd like to discuss about the structure of the menu in general. Therefore I'll clarify my previous post:
In v0.5 we had a menu like this: So the structure was:
(As RP 1.0 handles "other origins", besides The menu structure could be kept as above, but I'd like to emphasize the
So the
|
I'd agree that the first option is better. I suppose I was rather vague about the UI style :D Whether the options are in the topmenu/"main menu" like in NoScript, or in a submenu like in your image, the important thing is that they are there and accessible without needing to navigate away from the current tab. |
I agree with this. There should be a third action available to trust a destination only from the current domain (e.g. I trust youtube.com to request data from google.com, but not other sites to do so)
Agreed. Having the action in the submenu looks like the best option.
I think this is reasonable.
Actually @aggroskater you made my point. I'm not opposed to the 0.5x style menu, as long as it preserves some features that the 1.0 menu has:
the current 1.0 menu lacks the first-level |
okay @nodiscc, I agree completely.
click on the origin and you'll get this option: |
Sidenote: I find both the 0.5.x and 1.0.x menus usable. I'm in agreement with @nodiscc about making sure all of the options are still available though regardless of which UI is present. If time is scarce, then we can always let the 0.5.x-style context menu option slip to a later point release --or even figure out a way to tweak (or else permit the user to tweak) the 1.0.x-style menu sufficiently such that including the older style isn't necessary. |
|| slashdot.org Clicking on the icon on the left would toggle between Allow/Deny (from slashdot.org) || Allow fsdn.org (temporary) And: || Deny rpxnow.com (temporary) With the icon on the left toggling allow/denies, then you don't need to show Denies AND Allows in the submenu, making the interface cleaner for those that want a simpler one. Customize Rule would open the main rules page, with those domains prefilled in the text boxes Or Cutomize Rule, or another phrasing could just temporarily open the new 1.0 menu that we have now in all it's glory. Personally, I'll just keep using the new Drop-down, its really good. |
Personally I prefer the new menu for being able to enable a bunch of sites without having to open the menu again for each, and for not having to be precise with mouse movements to avoid closing submenus. Controlling submenus with clicks instead of mouse position is far better. |
Another voice for at least some kind of context menu, old or new. I would like my Firefox to stay clutter-free and would appreciate a context menu entry option. Hopefully this is still being worked on. edit: awesome! |
Hi @riesza, the milestone for this issue is 1.0 stable. |
Hi, is the right click menu already functional? I have installed the latest beta but there is only a button in the toolbar. I'll downgrade to FF 37.0.2 until this works. Thank you for your efforts. |
I was even so desperate to edit the em:maxVersion in the install.rdf of the 0.5.28 release because I want the context menu but it gets blocked anyway. |
If you don't want to litter your toolbar with the RP icon there's a shortcut to bring up the menu: ctrl+alt+R |
@noisybe if you want to use the old 0.5 version, you can try RPC 0.5; I've just uploaded it to AMO, it should work – but don't forget to uninstall legacy RP. The right-click menu is not there yet. It's currently planned for 1.0.beta12 |
@myrdd wow.. I hadn't found that. Thank you! <3 Looking forward to 1.0.beta12 :) |
@noisybe you're welcome! Btw, you did not find it because it's still in the AMO Review Queue. |
Fixes RequestPolicyContinued#353 Other changes: * `AUTHOR_SHEET` must be used instead of `USER_SHEET`
edit by @myrdd
RequestPolicy 0.5.x had an entry in the right-click context menu, see this screenshot:
In v1.0 beta this additional menu disappeared. This issue is about getting that menu back.
original post
Issue by Dinoso
Wednesday Nov 28, 2012 at 17:59 GMT
Originally opened as RequestPolicy/requestpolicy#353
Hi,
please add an option to have the menu of version 0.5 again. I was familiar with right-clicking whereever I was, move cursor to requestpolicy, do my action (sorting is already filed here, so I won't go into this) and after clicking whatever I wanted to, the menu closed and depending on my preferences the site was reloaded or not.
I really like the new features, but I want the old (quicker) behaviour again, at least as an option.
The text was updated successfully, but these errors were encountered: