-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the project's website #445
Comments
This discussion is very educational re hosting builds on GitHub :) Is it possible to provide |
I's actually possible to serve
I can take care of creating the branch, and a very simple HTML homepage for the project (basically copy contents from https://requestpolicy.com there + add a link to the releases page). It would be at http://RequestPolicyContinued.github.io/requestpolicy What do you think?
This would require someone to host it (including costs and availability requirements). IMHO not very portable/practical, a better alternative is using Github Issues as a discussion means, and tag these threads as So we can have code+update rdf+website+doc+forum on a single host, 2 commands away from a full backup/fork. |
@kwill looks like we had the same idea about at the same time... |
great! Go ahead! 👍 We could create a custom subdomain, e.g. requestpolicy.github.io (if it's possible), then it's independant from the real organization's name "RequestPolicyContinued". Also, the name would be shorter. What do you think? Yes, I think it's better to keep all discussion on this forum, at the moment. |
Yes!
Not possible because requestpolicy.github.io is reserved for https://github.com/requestpolicy (original organization by @jsamuel). I think we can live with the current requestpolicycontinued.github.io until @jsamuel takes a decision (merge our changes, transfer ownership, whatever... if it's not possible then we can keep requestpolicycontinued as this will effectively be a separate project). |
ok. |
I have set up a homepage for the project, it is viewable at https://nodiscc.github.io/requestpolicy/ Feedback welcome, I'll push it to this repository when it's fine for everyone. |
Great! I will read it through. But I've already recognized that you make use of JavaScript. Please do not do that, especially not for the download button! If you need this for the contributors list, that's ok if this is the only possible way. But there is no contributors list yet, no? As for the install button, you might do something like <a><span>Download</span><span>addon for Mozilla Firefox</span></a> and then define |
I'd prefer it without js also. Fixing it asap. There is a contributors list at https://nodiscc.github.io/requestpolicy/#about (right side) but it's quite empty - part of what I said in RequestPolicy/requestpolicy#407 (comment). So the about/credits/donations section is still undecided. |
I did a bit of work on this, feel free to check. |
Some suggestions:
|
Hi @kwill , thanks for your feedback
Anyone, feel free to submit changes/pull requests to the doc at https://github.com/nodiscc/requestpolicy |
What do you think? |
I've made some changes to the readme in the (paragraphs on the very top). Could you please review them? Thanks. |
@nodiscc did you try to contact him? I wrote two emails to him some weeks ago, but he didn't reply. If he won't reply at all, what will we do? I think we shouldn't just copy his texts, because of:
But rewriting the text is quite some work… |
Hi everyone, I'm sorry for my lack of communication. I would be very happy and quite relieved to put a single person in charge of RequestPolicy development, the GitHub organization, and the website. From there, they could organize other contributors as they see fit. For good and hopefully obvious reasons, the big obstacle is trust. Question: is there a single person here who everyone would want to see taking over the project and who wants to take over the project? |
Hi @jsamuel, I'm really happy to hear from you! Great to hear you're willing to help us continue the project! Of course I understand that trust is important for you, especially if you want to transfer both github project and website! It's up to you to decide. One idea could be to continue development on this repository (RequestPolicyContinued) for the time being. As soon as we reach a version which we consider as stable, you can take a look it and decide. However you decide, I think I'm the only one developing (programming) RP at the moment – at least I don't know about anyone else. So in case you'd hand over development to me, that would be a great honor for me. But however you decide, I'll be happy developing RP. About the website: I think it might be useful to move it to github, or to let the community work on it in any other way – but I'm uncertain about this. |
Great to hear from you! Thanks for your work on RP, I've been using it for as long as I can remember, it's awesome. Indeed there is a very valid trust question. Easiest things first, Website: you can already pull my work from https://github.com/nodiscc/requestpolicy/tree/gh-pages to your For addon code, The way I'd prefer it to be:
Of course you may not have time or will to maintain RP anymore, in this case there are other options:
What do you think? @myrdd I've added a comment on ad5aaa2, can you check? ( |
I did some work on the website (see above commits)
Linking directly to the xpi on github won't work (triggers a download dialog, not addon installation). The stable addon should be uploaded to addons.mozilla.org when it's ready. Then link to the xpi, or to the addon page.
As long as you mark dev releases as "Pre-release" in the github releases pages I think it's fine. Proper, production-ready XPIs will appear in green, betas in orange. But we should upload this to addons.mozilla.org to keep it clean (and get rid of the above problem).
Will update this when it's done, feel free to edit the doc - I will push it to |
website pushed at https://requestpolicycontinued.github.io/requestpolicy/, website link on https://github.com/RequestPolicyContinued/requestpolicy updated |
Looks good! Thank you for your work! What you've suggested about the xpi is ok for me. |
On the website, there are broken sentences at the end of the 3rd and 4th paragraphs on clickjacking. |
* work on #445 * thanks to @SkySkimmer
I've rewritten the site in Markdown to speed things up and make maintenance easier. Once it's complete, it will include contents of the website, the wiki, and some parts of the README that really belong in the documentation. Current status: https://github.com/nodiscc/rp-website/wiki. Then we can proceed to
Remaining todo:
@myrdd are you ok with this? I think having everything in one place will be easier to maintain, and easier for users/contributors to look for info. |
I think it's a good plan to have everything in one place. Let me know when I should review something. |
The project's website, wiki and README have been merged in https://github.com/nodiscc/rp-website/wiki.
Any feedback on the wiki contents/layout is highly appreciated. |
|
So far I've read the pages main, privacy, security and half of quickstart carefully. This is what I took note of: general note
So for example on the main page, I'd change „What does RequestPolicy Continued do?“ to „What does RequestPolicy do?“ pages
|
I've accidentally pushed the submit button, but now my above comment is complete. |
I agree with myrdd (just above). In https://github.com/nodiscc/rp-website/wiki/quickstart.md (one of the 13 pages linked at the 'Top Right' of In the section:
My suggested wording would be to change the second sentence:
I understand "you are tired to deal with" but I can't think how to put this is better English.
Note: Each action has a Temporarily block/allow alternative. This will add a temporary rule that will be removed when you click the Revoke temporary permissions menu item. When you close Firefox all temporary rules are forgotten. Almost off topic - a question about RP rules and e10s: I'm not using e10s (because NoScript can't). Will the RP rules be the same for ALL Tabs? I think they will. With RP 0.5.28 and RPC 1.0.beta9.3 (and not using e10s) all Temporary Rules are applied (work) until they are revoked on all Tabs / Windows. I very rarely add Rules - I nearly always use Temporary Rules.
Back to 'quickstart.md page', at the end we have:
|
+1 for @DJ-Leith's suggestions. Hm, maybe the button should be renamed? about off-topic:
@DJ-Leith if this was your only off-topic question, the answer is yes. |
Thanks for confirming, @myrdd. myrdd said:
Just to be clear, the word "all" is already in the 'link wording': I had previously said:
Next is a screenshot of what I was describing: On this Profile, used for the screenshot, the 'whitelist' does not have any "github.com".
In RPC 1.0.beta9.3, the 'option I was talking about', already has "all". As for the 'rules vs permissions' question: I agree, be consistent and call them "Rules". They are called "Active Rules" in So, "Rules" is used widely. @myrdd, if you do change the wording to "Revoke all temporary rules" then it is (see above):
to become: Note: Each action has a Temporarily block/allow alternative. This will add a temporary rule that will be removed when you click the "X" to Revoke the temporary rule (in It would be good to have screenshots to illustrate. |
Oops, that's right. So "all" doesn't need to be added.
I think this is way too long…
Screenshot would be OK for me, but not necessary. — That's just my two cents. |
Sorry for the lack of updates, I'm short on time :/ I've added checkboxes for each point that needs action in the wiki, https://github.com/nodiscc/rp-website/wiki is world-editable, so anyone is free to edit it and I'll review changes after the fact. |
Copied from #661 (comment):
|
Thanks for pointing that out! Thanks also for your summary.
|
@nodiscc in #665 I have posted some screenshots. |
nodiscc said:
I appreciate that. You have still 'done plenty' in the last few days!
I was reluctant to 'mess up' your good work. I did however make two changes to
I also saw that there are now two links, "For more advanced topics, you can read the documentation below" at the end for:
Thanks very much. |
Go ahead, as I said I'm notified of changes through RSS (with full diffs). Thanks for your fixes @DJ-Leith I'll do the button changes soon. The hard part is now to provide a conversion script for Github's wiki markdown -> HTML while preserving links, tables and other formatting, and optionally providing a prettier style than the default wiki style. I'll write a bash script that we could adapt to a Makefile (I'm very bad at makefiles). |
The new website/wiki is live at https://requestpolicycontinued.github.io/ and https://github.com/RequestPolicyContinued/requestpolicy/wiki
You just have to run Please review, report and fix any problem you may find. The wiki is world writable, just clone https://github.com/RequestPolicyContinued/requestpolicy.wiki.git, edit and push your changes, and I will gladly sync the changes to the website repo. |
wow @nodiscc great! Thank you for your effort! A few questions:
|
I know that
You can also update it anytime by
:/ I was confident that I had the latest revision. It should still be in my reflog, I'll restore it ASAP.
I started a fresh branch (orphan) to keep a clean history of the new website. I will restore the old version to a separate branch |
Issue list for the website/wiki moved to https://github.com/RequestPolicyContinued/RequestPolicyContinued.github.io/issues |
Alright @nodiscc, thanks for your quick reply!
Just speculating: maybe you have checked online the history of the „Home“ page instead of the complete history? The page-specific links are on each wiki page, whereas the latter link is more hidden. In any case, nevermind, just make sure to backup and re-check the current version the next time you'll be „overwriting“ a remote branch. Still, if you have the changes in your reflog, that would be great!
Does this issue still have a purpose? If not, let's close it. :) |
Summary:
xpi
extention file on https://sslsites.de/requestpolicy.256k.de/ (it hosts also update-beta.rdf)Content-type: text/xml
for the update-beta.rdf file, which is (I think so) not possible on github.So what to do?
Additionally, as soon as we have a stable version, it might be nice to have an own domain for PR (which might contain a forum). – no idea if we'll take over requestpolicy.com or if we'll have our own.
long version (so far)
This copy-pasted discussion is from https://github.com/RequestPolicyContinuedTmp/requestpolicy/commit/d7f4da7fbfbe2abbc82f372e61b9ee848fc60870#commitcomment-7408303
(I'm posting it here because I'll remove the RequestPolicyContinuedTmp organization soon.)
The text was updated successfully, but these errors were encountered: