Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support per-window Private Browsing #533

Closed
myrdd opened this issue Dec 3, 2014 · 2 comments
Closed

support per-window Private Browsing #533

myrdd opened this issue Dec 3, 2014 · 2 comments

Comments

@myrdd
Copy link
Member

myrdd commented Dec 3, 2014

This will probably also fix #531 and #532.
This issue is part of #526.

from the list on this MDN page RP uses nsIPrivateBrowsingService and observes private-browsing.

Supporting per-window private browsing

Per-window private browsing has been introduced in Fx20, so that will be the minVersion.

@myrdd
Copy link
Member Author

myrdd commented Jan 6, 2015

I've tried to implement support for per-window Private Browsing right now, but I've discovered that some bigger changes are necessary for full support.

  • Currently, when a user has a browser with the old Private Browsing Mode, at the time leaving the PBM all temporary rules are revoked.
  • For per-window Private Browsing it's necessary to have per-window temporary rules – or what do you think?

However, it's easy to forbid adding permanent rules in a window that is private, so I'll go with that option for now.

@myrdd myrdd changed the title support Private Browsing Mode support per-window Private Browsing Jan 6, 2015
myrdd added a commit that referenced this issue Jan 8, 2015
@myrdd myrdd modified the milestones: 1.0.beta9, 1.0.beta11 Apr 28, 2015
@myrdd
Copy link
Member Author

myrdd commented Jan 2, 2016

I won't implement per-window temporary rules. However, adding permanent rules in a private window is not possible by default. This has been fixed in commit e17c52d already.

@myrdd myrdd closed this as completed Jan 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant