New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PSAT active task #289
PSAT active task #289
Conversation
@@ -216,6 +216,16 @@ | |||
"REACTION_TIME_TASK_ATTEMPTS_FORMAT" = "Attempt %D of %D"; | |||
"REACTION_TIME_TASK_ACTIVE_STEP_TITLE" = "Quickly shake the device when the blue circle appears"; | |||
|
|||
/* PVSAT active task. */ | |||
"PVSAT_TITLE" = "PVSAT"; | |||
"PVSAT_INTRO_TEXT" = "The Paced Visual Serial Addition Test mesures your visual information processing speed and calculation ability."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"mesures" is misspelled
_answerCaptionLabel.textAlignment = NSTextAlignmentCenter; | ||
_answerCaptionLabel.translatesAutoresizingMaskIntoConstraints = NO; | ||
_digitLabel = [ORKTapCountLabel new]; | ||
_digitLabel.textColor= [self tintColor]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a space before =
.
@julientherier Are you developing this for an app for MS, or just a new task that’s being added outside the context of an app? |
"size" : "76x76", | ||
"idiom" : "ipad", | ||
"filename" : "Icon-76@2x.png", | ||
"scale" : "2x" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make a separate PR to add these app icons? They are not quite relevant to PVSAT task.
@YuanZhu-apple yes, the goal is to build an app for MS based on several new tasks. |
Below is my questions:
|
We can now choose stimulus duration as well as track dyad to overcome the “alternate answer” strategy. |
Thanks for your quick turnaround. Some UI feedback: Also I feel the color of the number ought to be black instead of app's tint color. |
I fixed these 2 problems. |
Maybe a guide |
|
||
/// The PAVSAT (Paced Auditory and Visual Series Addition Test). | ||
ORKPSATVersionPAVSAT | ||
} ORK_ENUM_AVAILABLE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make a bitmask instead? It seems basic versions can overlap.
ORKPSATVersionAudio = (1 << 1),
ORKPSATVersionVisual = (1 << 2),
version = ORKPSATVersionAudio | ORKPSATVersionVisual;
And bitmasks should use the NS_OPTIONS macro.
Name Version
could be confusing as incremental test versions
.
Consider to naming it ORKPSATOption
or ORKPSATStimuliOption
?
@YuanZhu-apple I'll be able to improve it on Friday, sorry for the delay. |
NSString *answerButtonTitle = nil; | ||
for (NSUInteger i = ORKPSATMinimumAnswer; i <= ORKPSATMaximumAnswer; i++) { | ||
answerButtonTitle = [NSString stringWithFormat:@"PSAT_BUTTON_TITLE_%li", i]; | ||
answerButton = [self answerButtonWithTitle:ORKLocalizedString(answerButtonTitle, nil)]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method may save some effort in localization:
[NSNumberFormatter
localizedStringFromNumber:[NSNumber numberWithInt:number]
numberStyle:NSNumberFormatterNoStyle];
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I'll use the same method for the digit series too.
Thanks a lot for this clue.
@YuanZhu-apple I tried with an iPhone using an Arabic language and I think it's OK. Please could you confirm that? |
@julientherier I confirm that the localized number works. |
@YuanZhu-apple any news about this PR for the past month? |
|
@julientherier Can you update this PR? I am about to merge it. |
Merged in 445d8af |
@YuanZhu-apple sorry I'm out of office for some days. Do you need more work for this PR? |
@julientherier That's OK. If find anything wrong from my merge, let me know. |
This pull-request adds a new active task: PSAT (Paced Serial Addition Test).
It is a test that supports both auditory (PASAT) and visual (PVSAT) versions.
This task is well documented in the scientific literature [Fos et al., 2000, Nagels et al., 2005], and is mainly used to mesure the MSFC score in Multiple Sclerosis.
Practically speaking, this task generates a series of single digits (e.g. 60), at the specific frequency (e.g. 1 new digit every 2 or 3 seconds). The user must add the newly presented digit to the one prior to it.
You can test this new task directly with the
ORKCatalog
application.Please feel free to comment code and scientific aspect of this PSAT task.
Task in action: