Hole Peg Test task #373
Hole Peg Test task #373
Conversation
|
@julientherier Can you send an email to researchkit@apple.com? So I can send you a copy of our contribution agreement before merging your two other pending requests. |
|
@YuanZhu-apple thanks. You should have received the email with accepted terms. |
|
For the instruction animation, to let the user better understand how to move the peg, can we add two 'pinch gesture fingers' around the peg? Normally user is get used to use one finger to move an object on iPhone or iPad. |
|
|
||
| - (instancetype)initWithOrientation:(ORKSide)orientation rotated:(BOOL)rotated NS_DESIGNATED_INITIALIZER; | ||
|
|
||
| @property (nonatomic, assign) ORKSide orientation; |
There was a problem hiding this comment.
Does orientation mean 'from left to right' / 'from right to left' ? If so, do you think rename it to ORKSide movingDirection can make it less confusing?
There was a problem hiding this comment.
Yes, you're right. I'll rename this property.
|
@rsanchezsaez thanks for this feedback. I don't think people need to understand that they'll remove the previously placed pegs. In fact, it is more a physical constraint in a real 9-Hole Peg Test I believe. If I can, I'll try to add more "flamboyance", it'd be fun. Oh, and thanks again for the great graphics! |
Merge master to fix conflicts.
|
@julientherier: Cool, good to know! No problem. |
|
@julientherier Sorry, I just get back to this one. Everything looks very good.
|
| /** | ||
| Body side constants. | ||
| */ | ||
| typedef NS_ENUM(NSInteger, ORKSide) { |
There was a problem hiding this comment.
I kind of like ORKBodySagittalLeft and ORKBodySagittalRight from @DanKeen, what do you think?
|
@YuanZhu-apple I think it should do the job. It's the first time I've upgraded a branch from an upstream, hope I did manage merging well. I did a thorough review of the code then, but sorry if I've missed something. Have you seen the @rsanchezsaez comment?
Should I need to remove the spoken instructions? |
|
Thanks for the code update! |
|
@YuanZhu-apple @rsanchezsaez thanks for all your advices. |
| @"Tower Of Hanoi Task", | ||
| @"Two Finger Tapping Task", | ||
| @"PSAT Task", | ||
| @"Timed Walk Task", |
There was a problem hiding this comment.
@julientherier Can you take a look at ORKTest again? I didn't see Hole Peg Test in the list.
There was a problem hiding this comment.
@YuanZhu-apple you're right, my bad. I added the Hole Peg Test task and also fixed an issue with the method name.
|
Thanks @julientherier ! |
|
@julientherier @YuanZhu-apple: Sorry to comment after this has been merged. We are trying to keep the Active Tasks alphabetically sorted within |
|
I'll submit a PR reordering it, and I'll create a new |
|
@rsanchezsaez Sure! |
This pull-request adds a new active task: HPT (Hole Peg Test).
This task is well documented in the scientific literature to mesure the MSFC score in Multiple Sclerosis or Parkinson Disease for instance Earhart et al., 2011.
It is one of the three tasks needed to assess the MSFC score:
• T25FW
• PASAT.
• 9-Hole Peg Test (this PR).
Practically speaking, this task generates a two step test where participant must put a variable number of peg in a hole, and then remove them. This task tests both hands.
You can test this new task directly with the ORKCatalog application.
Please feel free to comment code and scientific aspect of this HPT task.
Task in action: