Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition of RepositoryObject in ro-crate-context is wrong (#object instead of #Object) #243

Closed
ptsefton opened this issue Apr 26, 2023 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ptsefton
Copy link
Contributor

ptsefton commented Apr 26, 2023

Describe the bug
In the context https://w3id.org/ro/crate/1.1/context https://w3id.org/ro/crate/1.1/context

RepositoryObject is mapped to http://pcdm.org/2016/04/18/models#object -- should be http://pcdm.org/2016/04/18/models#Object (capital O)

@ptsefton ptsefton added the bug Something isn't working label Apr 26, 2023
@ptsefton ptsefton self-assigned this Apr 26, 2023
stain added a commit that referenced this issue Apr 26, 2023
@stain
Copy link
Contributor

stain commented Apr 26, 2023

This is a typo in the JSON-LD only, and the main point of mapping is for interoperability.

Fixed for 1.2 -- will also do a maintenance update on 1.1 context. The text in https://www.researchobject.org/ro-crate/1.1/metadata.html#additional-metadata-standards already claims it is mapped to the correct #Object.

@stain stain closed this as completed in 41ab2b7 Apr 26, 2023
@stain
Copy link
Contributor

stain commented Apr 26, 2023

Now live for 1.1, also released in https://github.com/ResearchObject/ro-crate/releases/tag/1.1.3 and https://doi.org/10.5281/zenodo.7867028 -- I did it as a quick patch to the HTML in the deposit is still claiming to be 1.1.2

@stain stain modified the milestones: RO-Crate 1.2, RO-Crate 1.1 May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants