Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ad-hoc terms use DefinedTerm/Class/Property #232

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Ad-hoc terms use DefinedTerm/Class/Property #232

merged 1 commit into from
Mar 23, 2023

Conversation

stain
Copy link
Contributor

@stain stain commented Jan 17, 2023

http://schema.org/DefinedTerm is better than http://schema.org/Thing for pre-existing URIs that are semantic artefacts or concepts. Somewhat equivalent to skos:Concept. This will then be consistent with https://www.researchobject.org/ro-crate/1.2-DRAFT/profiles that also mentions http://schema.org/DefinedTermSet.

For simplification with the profiles, rdf:Property / rdfs:Class types now optional, so we can stay in schema.org land for lightweight properties using their equivalent http://schema.org/Property and http://schema.org/Class. The RDFS variants are needed to do rdfs:subPropertyOf or rdfs:subClassOf but not I think needed for just adding a few terms to JSON-LD.

The part about @context and ad-hoc terms will still need to be updated to show that a RO-Crate Profile Crate could be used directly as a @context to use its terms there.

Also fixed some bugs in the expanded RDFS code from #208 (as @id is needed for object references in our JSON-LD).

rdf:Property / rdfs:Class now optional so we can stay in schema.org
land.
@stain
Copy link
Contributor Author

stain commented Jan 26, 2023

@stain stain added the profile label Feb 27, 2023
@stain
Copy link
Contributor Author

stain commented Mar 23, 2023

Merging without review as call 2023-03-23 agreed to merge all outstanding PR (that are not WIP) so we can do an overall review and push out 1.2.

@stain stain merged commit 2c46df4 into master Mar 23, 2023
@stain stain deleted the DefinedTerm branch March 23, 2023 20:56
@stain stain added this to the RO-Crate 1.2 milestone Mar 23, 2023
@stain stain mentioned this pull request Apr 28, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant