Handle step input mappings with no source #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the specific error reported in #33, but then the conversion of the sample RO bundle breaks again due to another error:
AttributeError: 'list' object has no attribute 'rsplit'.The problem fixed here is due to the fact that we were not dealing with steps whose input mapping might not have a
source. In this case, it only has avalueFrom. In this case, we fix the code by skipping the mapping, since it's not a connection with another parameter but an arbitrary Javascript expression. Note that CWL Viewer does the same (theoutnamemapping is not represented):