Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle outputs with multiple output sources #43

Merged
merged 2 commits into from
May 26, 2023

Conversation

simleo
Copy link
Collaborator

@simleo simleo commented May 26, 2023

E.g.:

outputs:
  out_file:
    type: File
    outputSource:
      - date/date_out
      - isodate/date_out
    pickValue: first_non_null

Similar to #31.

This fixes the error that was triggered by the RO bundle provided in #33 after #38 fixed the original one (see #38). Unfortunately the conversion of that bundle still fails, this time with:

RuntimeError: packed.cwl#workflow_prepare_fasta_db.cwl has no corresponding action

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06 🎉

Comparison is base (8ab22b7) 97.19% compared to head (56dd1a7) 97.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   97.19%   97.25%   +0.06%     
==========================================
  Files          11       11              
  Lines        1746     1786      +40     
==========================================
+ Hits         1697     1737      +40     
  Misses         49       49              
Impacted Files Coverage Δ
src/runcrate/convert.py 97.56% <100.00%> (+<0.01%) ⬆️
tests/test_cwlprov_crate_builder.py 99.87% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@simleo simleo merged commit b1c02bb into ResearchObject:main May 26, 2023
11 checks passed
@simleo simleo deleted the array_outputsource branch May 26, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant