Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroundTruth Refactor #422

Merged
merged 10 commits into from
May 29, 2024
Merged

GroundTruth Refactor #422

merged 10 commits into from
May 29, 2024

Conversation

BryonLewis
Copy link
Contributor

@BryonLewis BryonLewis commented May 10, 2024

resolves #418

  • May be a slight performance penalty but I think it's better to have non-groundtruth provide a direct link to the ground truth so it can be used to toggle on/off.
  • The linked groundtruth will be the matching region with ground_truth=True with the newest date.
  • The ground truth is not shown by default and instead in RDWatch it will link to ground truth when you turn it on using the Layer buttons.
  • The groundtruth and model for the layer selections will enable/disable automatically based on the selected model. So groundtruth is inherently connected to the model-run instead of having to be toggled automatically.
  • Updated the scoring response to label ground-truth vs the regular items respectively in the list.
  • Updated the regular RDWatch response to label groundtruth vs the regular items as well.
RDWatchGroundTruth_small.mp4

@BryonLewis BryonLewis marked this pull request as ready for review May 15, 2024 16:16
Copy link
Member

@mvandenburgh mvandenburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left some code suggestions. Otherwise LGTM

vue/src/components/LayerSelection.vue Outdated Show resolved Hide resolved
@BryonLewis BryonLewis merged commit a89eece into main May 29, 2024
8 checks passed
@BryonLewis BryonLewis deleted the rdwatch-groundtruth-refactor branch May 29, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GroundTruth Interaction Update
2 participants