-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why do we allow 0x
descriptors?
#143
Comments
I got it very wrong - |
I'd be in favor of requiring |
Per irc discussions, 0x is basically like For 0w, we could drop it during parsing, but I don't see any benefit in doing so and there's a risk of introducing bugs with changing the algorithm. However we can basically disallow it by requiring that it match the image's actual width. |
Require that 'w' matches the image width. Fixes #143
It seems that the
x
descriptors are defined as non-negative integers. Shouldn't they be positive integers?The text was updated successfully, but these errors were encountered: