New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sockets from NIOHandler's KeyedSemaphore in all cases #4

Merged
merged 1 commit into from Jul 25, 2015

Conversation

Projects
None yet
2 participants
@mgroshans

mgroshans commented Jul 24, 2015

When removing a socket via NIOHandler::removeSocket(SocketChannel) there
is no call to remove the channel's key from the KeyedSemaphore. Fixed
this by making this method call NIOHandler::removeSocket(String) for
each key so that both cases clean up the same way.

Michael Groshans
Remove sockets from NIOHandler's KeyedSemaphore in all cases
When removing a socket via NIOHandler::removeSocket(SocketChannel) there
is no call to remove the channel's key from the KeyedSemaphore. Fixed
this by making this method call NIOHandler::removeSocket(String) for
each key so that both cases clean up the same way.

deruelle added a commit that referenced this pull request Jul 25, 2015

Merge pull request #4 from mgroshans/socket-cleanup
Remove sockets from NIOHandler's KeyedSemaphore in all cases

@deruelle deruelle merged commit c6a14d7 into RestComm:master Jul 25, 2015

@mgroshans mgroshans deleted the mgroshans:socket-cleanup branch Jul 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment