Remove sockets from NIOHandler's KeyedSemaphore in all cases #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When removing a socket via NIOHandler::removeSocket(SocketChannel) there is no call to remove the channel's key from the KeyedSemaphore. Fixed this by making this method call NIOHandler::removeSocket(String) for each key so that both cases clean up the same way.
deruelle
added a commit
that referenced
this pull request
Jul 25, 2015
Remove sockets from NIOHandler's KeyedSemaphore in all cases
deruelle
referenced
this pull request
in mobius-software-ltd/corsac-sip
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removing a socket via NIOHandler::removeSocket(SocketChannel) there
is no call to remove the channel's key from the KeyedSemaphore. Fixed
this by making this method call NIOHandler::removeSocket(String) for
each key so that both cases clean up the same way.