New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed eclipse error: Plugin execution not covered by lifecycle configuration #54

Merged
merged 8 commits into from Sep 19, 2016

Conversation

Projects
None yet
3 participants
@pmcgleenon
Contributor

pmcgleenon commented Aug 18, 2016

Eclipse gives a plugin lifecycle error which is fixed by this change

http://stackoverflow.com/questions/6352208/how-to-solve-plugin-execution-not-covered-by-lifecycle-configuration-for-sprin

Using eclipse STS v3.8.1

@deruelle

This comment has been minimized.

Member

deruelle commented Aug 26, 2016

hi @pmcgleenon, thanks for the pull requests ! Would you mind signing the Contributor License Agreement at https://telestax.com/open-source/#Contribute so we can accept them and acknowledge you at https://telestax.com/acknowledgements/

@pmcgleenon

This comment has been minimized.

Contributor

pmcgleenon commented Sep 1, 2016

hi, I've done that now. thanks

@deruelle

This comment has been minimized.

Member

deruelle commented Sep 8, 2016

Thanks @pmcgleenon . @brainslog can you review ?

@brainslog

This comment has been minimized.

Collaborator

brainslog commented Sep 19, 2016

Thanks @pmcgleenon for fixing those maven issues. I'd just wish that example1-1.7.0-SNAPSHOT-jar-with-dependencies.jar would not have the version qualifier, otherwise we'll need (and likely forget) to change it after each release. But that can be dealt with later. Merging, thanks.

@brainslog brainslog merged commit 6eb214b into RestComm:master Sep 19, 2016

@deruelle

This comment has been minimized.

Member

deruelle commented Sep 19, 2016

Thanks @pmcgleenon Contribution acknowledged at https://telestax.com/acknowledgements/

@brainslog brainslog added this to the 1.7.0.FINAL milestone Mar 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment