Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLS should support odd or even number #223

Closed
nhanth87 opened this issue Mar 29, 2017 · 9 comments
Closed

SLS should support odd or even number #223

nhanth87 opened this issue Mar 29, 2017 · 9 comments
Assignees
Milestone

Comments

@nhanth87
Copy link
Contributor

Oracle Communication has supported SLS odd and even for ss7 load balancing.
jss7 shoud have configuration for sls odd or even to adap it

https://www.dialogic.com/den/developer_forums/f/10/t/7280.aspx

@nhanth87 nhanth87 self-assigned this Mar 29, 2017
@faizann
Copy link
Contributor

faizann commented Mar 29, 2017

Hi

I thought Bit0 Algorithm for loadsharing does it already.

@nhanth87
Copy link
Contributor Author

Hi @faizann, we need configuration so the ss7 application is only send and receive with odd or even

Br,
TN

@nhanth87
Copy link
Contributor Author

if you config bit0 then you can't control if you just want to receive odd or even SLS

@faizann
Copy link
Contributor

faizann commented Mar 30, 2017 via email

@vetss vetss added this to the 7.3.0 milestone Mar 30, 2017
@nhanth87
Copy link
Contributor Author

hi @faizann in case of 2 ss7 application running replication with STP is Oracle Communication.
this fix is a part of #219

Br,
TN

@deruelle
Copy link
Member

deruelle commented Apr 4, 2017

Can we close this issue since it's fixed in #219 ?

@vetss
Copy link
Contributor

vetss commented Apr 4, 2017

@deruelle

#219 - is the issues for another case (m3ua). This issues is for TCAP stack. @nhanth87 need to provide configuring part to finish this case.

@vetss
Copy link
Contributor

vetss commented Apr 13, 2017

Hi @nhanth87

  1. I have committed you fix into non-netty branch. So we can build binaries and thest them at a customer side.
  2. I have added one little fix for the following reason:
    XML serializing / deserializing does now work fine if we add some new items at the end of the file because if internal algo reason. We need to follow a rule that if we update a list of items we need to add them in the middle, not at the end. Please follow this rule further.
  3. It is better to have in CLI interface not digital parameters but strings like "odd", "even", "all". It is not a critical issue but it is better to fix it. You can reuse some enum in configuring.
  4. it not a good way to add a special branch into a repo https://github.com/RestComm/jss7 for so little fix. Better if you create a branch in your repo (that was forked after). Please remove the branch in "RestComm" after we finish of this fix.
  5. We need to update also master branch.

@nhanth87 do you have a write access to repos ?

vetss added a commit to vetss/jss7 that referenced this issue Apr 27, 2017
Conflicts:
	tcap-ansi/tcap-ansi-impl/src/main/java/org/mobicents/protocols/ss7/tcapAnsi/TCAPStackImpl.java
vetss added a commit to vetss/jss7 that referenced this issue Apr 27, 2017
@vetss
Copy link
Contributor

vetss commented Apr 27, 2017

Fixed in non-netty branch by:
105b8a1
df448c2
5fa274b
90c3874
ef97d3c

Fixed in master branch:
c213ac9
11959c7
6c96a6c
19e3011
2a72336
85fbb1a

Thanks for your updates @nhanth87

@vetss vetss closed this as completed Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants