-
Notifications
You must be signed in to change notification settings - Fork 124
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thread, Memory & CPU leak using mobicents RTP #21
Comments
I've fixed the resource leaks. Let me know if you're interested in them. I can push my branch if you like. |
Hi Mitchell, Thanks for reporting and contributing with a fix. Much appreciated. Best Regards, |
Mitchell, Can you please sign the Contributor License Agreement (http://www.telestax.com/open-source/#Contribute) so I can accept your contribution? Also, would you like to be acknowledged for your contribution? (http://www.telestax.com/open-source/acknowledgments/) Regards |
I signed the contributor agreement, I guess I now wait for an invite or something? Sure, if you like my contribution, you can acknowledge it. You could also acknowledge a fix to jain-sip, issue 21, see https://java.net/projects/jsip/pages/Acknowledgements |
Thanks for signing the agreement. We're now trying to reach you over email. |
Mitchell, Can you please do a pull request so I can review your work? Thank you |
Hi Mitchell, Just checking on your progress, any news? Best Regards |
hey Henrique, sorry, been swamped here. I was planning on waiting until you had Mitchell On Mon, Jul 20, 2015 at 8:00 AM, Henrique Rosa notifications@github.com
|
Sure, take your time. Thanks |
… when it is started. Upon stopping the manager, these resources will be cleaned. Code cleanup of PortManager and UdpManager.
Properly naming the threads spawned by the Scheduler.
… when it is started. Upon stopping the manager, these resources will be cleaned. Code cleanup of PortManager and UdpManager.
hi mcacker, |
I would use the latest branch. The offending class has been completely refactored since I patched it. I can't verify that it no longer has a resource leak as i'm still using my older patched version. If you're stuck on that version for some reason, you can find my patch at #24 |
Hi Mcracker ,
} |
Sorry, this is beyond my knowledge of the mediaserver. I recommend you open a new Issue, perhaps one of the contributers can help. |
Hi @thanhthuy40 please open a thread in the public forum: https://groups.google.com/forum/#!forum/restcomm Thank you |
thank you hrosa |
Hi Mcracker , 21818 thanhhn5 20 0 4974880 197056 17952 S 6.5 3.4 0:15.94 java |
Chào Thuy, Br, |
Dear Nhanth87, |
fixed cannot parse string payload format Approved-by: Henrique Rosa <henrique.rosa@telestax.com>
Hi,
i'm using mobicents RTP to implements a media server and SBC monitor, by setting up a call and sending and receiving RTP. Unfortunately, whenever the call is stopped and restarted there is a Thread leak, memory leak and slowly increasing CPU usage, to the point that eventually the app crashes.
I've based it on the RTPChannelTest class.
the call setup is as follows:
and the tear down:
the problem appears to be in the Scheduler class, specifically the CriticalWorkerThread and the Worker thread where they remain in the WAITING state on the take statement (line 413) in
the Scheduler.stop() method only sets the 'active' boolean for the threads which can never be tested while the threads are in the WAITING state.
What is the correct way to stop the scheduler to prevent this thread leak?
I've thought of adding something to interrupt the threads, but there is an empty catch block which would just swallow the resultant interrupt.
Any guidance would be much appreciated as this is it makes my head hurt trying to get to grips with this code and how to fix my app or modify the code.
thanks, Mitchell
The text was updated successfully, but these errors were encountered: