Fixed problems with initial implementation of temporary managed objec…

…ts visitor. The implementation was under tested and only worked with a single relationship. refs #1001

Code/Network/RKObjectManager.m

@@ -281,7 +281,7 @@ - (id)initWithManagedObject:(NSManagedObject *)managedObject;
 
 @interface RKTemporaryManagedObjectVisitor ()
 @property (nonatomic, strong) NSMutableSet *mutableTemporaryObjects;
-@property (nonatomic, strong) NSMutableSet *mutableVisitedObjects;
+@property (nonatomic, strong) NSMutableDictionary *mutableVisitedObjectsToRelationships;
 @end
 
 @implementation RKTemporaryManagedObjectVisitor
@@ -296,9 +296,9 @@ - (id)initWithManagedObject:(NSManagedObject *)managedObject
 {
     self = [super init];
     if (self) {
-        self.mutableVisitedObjects = [NSMutableSet set];
+        self.mutableVisitedObjectsToRelationships = [NSMutableDictionary new];
         self.mutableTemporaryObjects = [NSMutableSet set];
-
+        
         if ([managedObject.objectID isTemporaryID]) [self.mutableTemporaryObjects addObject:managedObject];
         [[managedObject.entity relationshipsByName] enumerateKeysAndObjectsUsingBlock:^(NSString *relationshipName, NSRelationshipDescription *relationship, BOOL *stop) {
             [self visitObjectsAtRelationship:relationship ofObject:managedObject];
@@ -309,12 +309,18 @@ - (id)initWithManagedObject:(NSManagedObject *)managedObject
 
 - (void)visitObjectsAtRelationship:(NSRelationshipDescription *)relationship ofObject:(NSManagedObject *)managedObject
 {
-    if ([self.mutableVisitedObjects containsObject:managedObject]) return;
-    [self.mutableVisitedObjects addObject:managedObject];
-
+    NSValue *dictionaryKey = [NSValue valueWithNonretainedObject:managedObject];
+    NSMutableSet *visitedRelationships = [self.mutableVisitedObjectsToRelationships objectForKey:dictionaryKey];
+    if (!visitedRelationships) {
+        visitedRelationships = [NSMutableSet set];
+        [self.mutableVisitedObjectsToRelationships setObject:visitedRelationships forKey:dictionaryKey];
+    }
+    if ([visitedRelationships containsObject:relationship]) return;
+    [visitedRelationships addObject:relationship];
+
     id relatedObjectOrObjects = [managedObject valueForKey:relationship.name];
     if (relatedObjectOrObjects && ![relationship isToMany]) relatedObjectOrObjects = @[ relatedObjectOrObjects ];
-
+    
     for (NSManagedObject *relatedObject in relatedObjectOrObjects) {
         if ([[relatedObject objectID] isTemporaryID]) [self.mutableTemporaryObjects addObject:relatedObject];
         [[relatedObject.entity relationshipsByName] enumerateKeysAndObjectsUsingBlock:^(NSString *relationshipName, NSRelationshipDescription *relationship, BOOL *stop) {

Tests/Logic/ObjectMapping/RKObjectManagerTest.m

@@ -965,16 +965,16 @@ - (void)testThatPostingUnsavedObjectWithUnsavedChildrenDoesNotCrash
     expect([restkitTag.objectID isTemporaryID]).to.equal(YES);
 
     __block RKMappingResult *postMappingResult = nil;
-    [objectManager postObject:post path:@"/posts.json" parameters:nil success:^(RKObjectRequestOperation *operation, RKMappingResult *mappingResult) {
+    RKManagedObjectRequestOperation *operation = [objectManager appropriateObjectRequestOperationWithObject:post method:RKRequestMethodPOST path:@"/posts.json" parameters:nil];
+    operation.savesToPersistentStore = NO;
+    [operation setCompletionBlockWithSuccess:^(RKObjectRequestOperation *operation, RKMappingResult *mappingResult) {
         postMappingResult = mappingResult;
     } failure:nil];
+    [objectManager enqueueObjectRequestOperation:operation];
 
     expect(postMappingResult).willNot.beNil();
-    expect([post isNew]).will.equal(NO);
     expect([post.objectID isTemporaryID]).will.equal(NO);
-    expect([developmentTag isNew]).will.equal(NO);
     expect([developmentTag.objectID isTemporaryID]).will.equal(NO);
-    expect([restkitTag isNew]).will.equal(NO);
     expect([restkitTag.objectID isTemporaryID]).will.equal(NO);
 }