Fixed show/hide all text link on calendar page with no upcoming events #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added .gitattributes
why? |
|
@graymur Thanks for the PR, I updated description to use inline image vs the link. |
So we don't have problems with line endings between MacOS/Win |
|
@graymur we shouldn't have any, your local git setup should have default setting |
|
fixes #294 |
|
Test it out, great work, thanks a lot for the fix 👍 Idk what I was thinking when I added that check. |
|
We will have to fix the build though by fixing #298 since it can break production |
Restuta
approved these changes
Oct 18, 2017
Happens to the best of us) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added .gitattributes
Now when past events are hidden title will say "No upcoming events from Today (...)":
How to test
http://rcn-io-staging.herokuapp.com/calendars/usac-2017?past=visible