Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add core fetching script for Windows #37

Merged
merged 3 commits into from
Sep 11, 2018
Merged

Add core fetching script for Windows #37

merged 3 commits into from
Sep 11, 2018

Conversation

rzumer
Copy link
Contributor

@rzumer rzumer commented Aug 5, 2018

CRLF line endings are used in dl-cores.bat for compatibility reasons, and enforced in .gitattributes to avoid automatic conversions on Windows.

wget and unzip must be provided by the user.

Closes #36, and possibly #31 (please confirm).

@rzumer rzumer requested review from meleu and leiradel August 5, 2018 15:37
@rzumer rzumer changed the title Add dependency fetching script for Windows Add core fetching script for Windows Aug 5, 2018
Copy link
Contributor

@meleu meleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not used to .bat syntax, but looks fine for me. 👍

@leiradel leiradel merged commit 93a9478 into RetroAchievements:develop Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants