-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: denormalize and restore the Followed Users Ranking component #2448
Merged
wescopeland
merged 29 commits into
RetroAchievements:master
from
wescopeland:denormalized-followed-users-ranking
Jun 17, 2024
Merged
feat: denormalize and restore the Followed Users Ranking component #2448
wescopeland
merged 29 commits into
RetroAchievements:master
from
wescopeland:denormalized-followed-users-ranking
Jun 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…com/wescopeland/RAWeb into denormalized-followed-users-ranking
Jamiras
reviewed
Jun 2, 2024
Jamiras
reviewed
Jun 3, 2024
Jamiras
reviewed
Jun 6, 2024
Jamiras
reviewed
Jun 7, 2024
Jamiras
approved these changes
Jun 7, 2024
Preferably would like to see this one not included in 6.7.0, as there's already quite a bit of things merged for 6.7.0 and this one should be watched closely. If no objections, let's push this one to the release afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores the Followed Users Ranking component on user profiles. The component was previously replaced with a call-to-action due to how intensive it was in regards to DB performance. Now, player daily and weekly points summaries are denormalized into the
player_stats
table so the DB calls for the component are now essentially free, even for users that are following 1000+ other users.This PR is stacked on top of #2446.
Before
After
How it works:
UpdatePlayerPointsStats
, which inserts denormalized points summary values for a user's daily/weekly hardcore, weighted, and softcore points into theplayer_stats
table.PlayerMetricsUpdated
and onPlayerRankedStatusChanged
.value
hits 0, it is hard deleted fromplayer_stats
by a tiny command:DeleteStalePlayerPointsStatsEntries
. This can't be insideUpdatePlayerPointsStats
itself without causing race conditions.How to test this PR:
UpdatePlayerPointsStats
is exposed through a new Artisan Console command. The command also accepts mock dates to improve testing.