ignore achievements with no retro ratio when determining easiest achievements #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newly created achievements have a retro ratio of 0. As such, they appear "easier" than all other achievements. There are currently around 5300 achievements with a retro ratio of 0. This filters those out so actual easy achievements appear in the "Easy Achievements" page. Unfortunately, there are around 7000 achievements with a retro ratio of 1, so identifying the "easiest" achievements is still far from perfect.
A secondary sort was also added to subclassify items within the same retro ratio by their point value. i.e. a 1 point achievement with a retro ratio of 2 is harder than a 2 point achievement with a retro ratio of 2.