Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1574 previous button incorrect behaviour #1590

Closed
wants to merge 1 commit into from
Closed

fix: #1574 previous button incorrect behaviour #1590

wants to merge 1 commit into from

Conversation

rahul-gill
Copy link
Contributor

@rahul-gill rahul-gill commented Dec 22, 2023

Fix for the issue #1574

@prathameshmm02
Copy link
Member

prathameshmm02 commented Dec 30, 2023

Thanks for the PR.
I added this behaviour to support song change from earphones, e.g. I want to go back to previous song then I can just double tap my left earphone of my TWS, or maybe triple tap on wired earphones.
But if we call musicService.back(true), then if I want to go to previous song, I have to do the above skip action twice, in my case, double tapping my left earphone twice which is a pain tbh.
But this behaviour also affects notification, so if you can separate both things(Notification action and Earphone action) that would be great.

@rahul-gill
Copy link
Contributor Author

Outside controllers can't be differentiated so we can add a preference to enable this behavior when headsets are connected

@rahul-gill
Copy link
Contributor Author

I've added two preference in the Other settings screen to customize this behavior seperately for wired and bluetooth devices.
By default previous button will seek to start of the song
Enabling those preferences will make previous button play the previous song

@rahul-gill rahul-gill closed this by deleting the head repository Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants