Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Minecraft Pi module #1702

Merged
merged 3 commits into from Sep 27, 2016
Merged

Update the Minecraft Pi module #1702

merged 3 commits into from Sep 27, 2016

Conversation

ghost
Copy link

@ghost ghost commented Sep 27, 2016

I have updated the Minecraft Pi module to be more convenient and relevant.
:)

Updated the Minecraft Pi module to be more relevant.
@joolswills
Copy link
Member

joolswills commented Sep 27, 2016

Thanks - please can you be more specific as to improvements with the packaged version?

I would probably avoid the module rename - saves having an extra update hook to run and it will need to clean up the old folder etc. I think it might just be best to leave it called minecraft for now - if we need the namespace in the future that can be changed then.

@ghost
Copy link
Author

ghost commented Sep 27, 2016

The packaged version throws Python 2 out the window as it is legacy stuff now, in favor of Python 3.

@ghost
Copy link
Author

ghost commented Sep 27, 2016

Also, the accompanying Python module will be installed globally along with the game.

@joolswills
Copy link
Member

Thanks. The update hook won't be needed now since the install folder will now exist - I will need to perhaps remove the contents of it though if not empty. If you can remove the update, I will merge and do the folder cleanup bit.

@joolswills joolswills merged commit b0c8d27 into RetroPie:master Sep 27, 2016
@ghost
Copy link
Author

ghost commented Sep 27, 2016

Well, thanks! I just learned a little more about the RetroPie module format!

@joolswills
Copy link
Member

I made a couple of changes - also keeping the addPort name as just "Minecraft" otherwise you get an additional launch script (which means we would need to clean up the old one - but I'm ok with just plain Minecraft.sh)

@ghost
Copy link
Author

ghost commented Sep 27, 2016

Ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant