Update abuse.sh #2450
Closed
Update abuse.sh #2450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change Description Add Help Change function configure_abuse()
joolswills
reviewed
Aug 8, 2018
| moveConfigDir "$home/.abuse" "$md_conf_root/abuse" | ||
| addPort "$md_id" "abuse" "Abuse" "pushd $md_inst; $md_inst/abuse; popd" | ||
| addPort "$md_id" "abuse" "Abuse port of run and gum game" "pushd $md_inst; $md_inst/abuse -datadir $romdir/ports/$md_id; popd" |
There was a problem hiding this comment.
the description "port of run and gum game" shouldn't be here (it's gun and not gum also).
psyke83
reviewed
Dec 4, 2018
| @@ -10,8 +10,9 @@ | |||
| # | |||
|
|
|||
| rp_module_id="abuse" | |||
| rp_module_desc="Abuse" | |||
| rp_module_desc="Abuse - port of run and gun game" | |||
| rp_module_license="GPL https://raw.githubusercontent.com/Xenoveritas/abuse/master/COPYING" | |||
There was a problem hiding this comment.
This isn't your fault, but if you do get around to updating the PR with Jools' other comments, it would be helpful if you fixed this typo as well. The function name is supposed to be the non-US spelling (rp_module_licence). Thanks.
|
Is this module working in relation to the instalation? in the past, I tried and always failed. |
|
The module is currently disabled. I just tested with adjusting the module to use manually installed game data and it wasn't working correctly in regards to joystick/keyboard input. I will close this PR though as it no longer applies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Add Help
Change function configure_abuse()