Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update golang to v1.8.7 and include arm64 version to fix arm64 compatibility #3420

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

cobalt2727
Copy link
Contributor

I can change this to https://golang.org/dl/go1.8.linux-$arch.tar.gz if that would be preferable. Comments left in as a reference if anyone ever wants to change it back to Google's servers

@cobalt2727
Copy link
Contributor Author

Actually, is there any reason this script doesn't just sudo apt install golang?

@cmitu
Copy link
Contributor

cmitu commented Oct 27, 2021

Does the new Go version work with scraper (the reason this scriptmodule exists) ?

@cobalt2727
Copy link
Contributor Author

Trying to use 1.17 resulted in the following, and while I do have an idea to resolve it, I figured it's probably a smarter idea to stick to 1.8 considering scraper hasn't been updated since 2019. 1.8.7 does have an arm64 download, so it all works out!

= = = = = = = = = = = = = = = = = = = = =
Getting sources for 'scraper' : Scraper for EmulationStation by Steven Selph
= = = = = = = = = = = = = = = = = = = = =

go: downloading github.com/sselph/scraper v1.4.6
go: downloading github.com/kjk/lzmadec v0.0.0-20210713164611-19ac3ee91a71
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: downloading github.com/hashicorp/golang-lru v0.5.4
go: downloading github.com/syndtr/goleveldb v1.0.0
go: downloading github.com/nfnt/resize v0.0.0-20180221191011-83c6a9932646
go: downloading github.com/golang/snappy v0.0.0-20180518054509-2e65f85255db
go: downloading github.com/golang/snappy v0.0.4
go get: installing executables with 'go get' in module mode is deprecated.
	Use 'go install pkg@version' instead.
	For more information, see https://golang.org/doc/go-get-install-deprecation
	or run 'go help get' or 'go help install'.
~

@cobalt2727
Copy link
Contributor Author

Does the new Go version work with scraper (the reason this scriptmodule exists) ?

Just ran it on my Jetson Nano, everything looks good

@cobalt2727
Copy link
Contributor Author

@cmitu could you look over this when you get the chance?

@cmitu
Copy link
Contributor

cmitu commented Nov 15, 2021

If scraper works with the new version, then it's fine.

@cobalt2727
Copy link
Contributor Author

cobalt2727 commented Nov 15, 2021

Can confirm it does on my laptop, Jetson Nano, and Raspberry Pi (which, granted, is also 64-bit, but I didn't mess with the architecture detection code for armhf, and it's almost the same version number of golang anyways)

@cmitu
Copy link
Contributor

cmitu commented Nov 15, 2021

I've tested it on armhf, since I don't have an aarch64 system, and it works.

@cobalt2727 cobalt2727 changed the title update golang, fix aarch64 not downloading update golang, fix CRITICAL arm64 scraper error Nov 21, 2021
@cobalt2727
Copy link
Contributor Author

i love clickbait

@cobalt2727
Copy link
Contributor Author

@joolswills You got a second? scraper is completely broken on arm64 devices without this change

@joolswills
Copy link
Member

I don't like clickbait / dramatic titles so please don't do that. It's not "CRITICAL". I will merge when I am ready.

@joolswills joolswills changed the title update golang, fix CRITICAL arm64 scraper error update golang to v1.8.7 and include arm64 version to fix arm64 compatibility Dec 5, 2021
@joolswills
Copy link
Member

joolswills commented Dec 5, 2021

Please can you squash the commits and I will merge.

@cmitu
Copy link
Contributor

cmitu commented Jan 18, 2022

@joolswills I guess this can be merged now ?

@joolswills
Copy link
Member

Yep. thanks.

@joolswills joolswills merged commit 313437c into RetroPie:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants