-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update golang to v1.8.7 and include arm64 version to fix arm64 compatibility #3420
Conversation
Actually, is there any reason this script doesn't just |
Does the new Go version work with |
Trying to use 1.17 resulted in the following, and while I do have an idea to resolve it, I figured it's probably a smarter idea to stick to 1.8 considering = = = = = = = = = = = = = = = = = = = = =
Getting sources for 'scraper' : Scraper for EmulationStation by Steven Selph
= = = = = = = = = = = = = = = = = = = = =
go: downloading github.com/sselph/scraper v1.4.6
go: downloading github.com/kjk/lzmadec v0.0.0-20210713164611-19ac3ee91a71
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: downloading github.com/hashicorp/golang-lru v0.5.4
go: downloading github.com/syndtr/goleveldb v1.0.0
go: downloading github.com/nfnt/resize v0.0.0-20180221191011-83c6a9932646
go: downloading github.com/golang/snappy v0.0.0-20180518054509-2e65f85255db
go: downloading github.com/golang/snappy v0.0.4
go get: installing executables with 'go get' in module mode is deprecated.
Use 'go install pkg@version' instead.
For more information, see https://golang.org/doc/go-get-install-deprecation
or run 'go help get' or 'go help install'.
~ |
Just ran it on my Jetson Nano, everything looks good |
@cmitu could you look over this when you get the chance? |
If |
Can confirm it does on my laptop, Jetson Nano, and Raspberry Pi (which, granted, is also 64-bit, but I didn't mess with the architecture detection code for armhf, and it's almost the same version number of golang anyways) |
I've tested it on |
i love clickbait |
@joolswills You got a second? |
I don't like clickbait / dramatic titles so please don't do that. It's not "CRITICAL". I will merge when I am ready. |
Please can you squash the commits and I will merge. |
@joolswills I guess this can be merged now ? |
Yep. thanks. |
I can change this to https://golang.org/dl/go1.8.linux-$arch.tar.gz if that would be preferable. Comments left in as a reference if anyone ever wants to change it back to Google's servers