esthemes: make it possible to patch themes locally #3813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joolswills
reviewed
Nov 24, 2023
|
Thank you for this. |
Added the ability to patch themes locally to fix the gamelist layout bugs in themes, surfaced after EmulationStation's fixes for positioning, added a in 2.10.x. Mostly done to fix @ruckage's themes, which haven't been updated after the new EmulationStation version. Fixes included: * for the 'snes-mini' theme, based on ruckage/es-theme-snes-mini#26, submitted by @makofee * for the 'nes-mini' theme, started from https://github.com/ruckage/es-theme-nes-mini/pulls/13, submitted by @grosa1, which in turn is based on https://retropie.org.uk/forum/topic/12583/snes-mini-theme/929?_=1699852993853 (?). Followed by some testing and fixing for the other resolutions which are not covered by the initial changes. * for the 'famicom-mini' theme, adapted from the previous patch with some adjustments added after testing each resolution supported.
cmitu
force-pushed
the
esthemes-fixes
branch
from
4a12147
to
244eb3f
Compare
|
Thanks. |
microplay-hub
added a commit
to microplay-hub/RetroPie-N3XT
that referenced
this pull request
Nov 28, 2023
microplay-hub
added a commit
to microplay-hub/RetroPie-N3XT
that referenced
this pull request
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to patch themes locally to fix the gamelist layout bugs in themes, surfaced after EmulationStation's fixes for positioning, added a in 2.10.x. Mostly done to fix @ruckage's themes, which haven't been updated after the new EmulationStation version.
Fixes included: