Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReactionController to disable button during submits #1533

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

pixeldesu
Copy link
Member

Fixes #1517 (actually, other changes beforehand fixed it already, but this one might as well close it)

Testing:

  • Make your internet slow, reload the page and try submitting the button multiple times. It should get disabled until the smile went through.

Note: Don't forget to rebuild JS.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (855d0fa) 95.71% compared to head (96aeb16) 95.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1533   +/-   ##
=======================================
  Coverage   95.71%   95.71%           
=======================================
  Files         174      174           
  Lines        2704     2704           
=======================================
  Hits         2588     2588           
  Misses        116      116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixeldesu pixeldesu merged commit 950443b into main Dec 20, 2023
13 checks passed
@pixeldesu pixeldesu deleted the fix/disable-reaction-button branch December 20, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entities can be smiled multiple times
2 participants