Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReactionController to disable button during submits #1533

Merged
merged 1 commit into from
Dec 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions app/javascript/retrospring/controllers/reaction_controller.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import { Controller } from '@hotwired/stimulus';

export default class extends Controller {
static targets = ['button'];

declare readonly buttonTarget: HTMLButtonElement;

enable(): void {
this.buttonTarget.disabled = false;
}

disable(): void {
this.buttonTarget.disabled = true;
}
}
2 changes: 2 additions & 0 deletions app/javascript/retrospring/initializers/stimulus.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import NavigationController from "retrospring/controllers/navigation_controller"
import ShareController from "retrospring/controllers/share_controller";
import ClipboardController from "retrospring/controllers/clipboard_controller";
import QuestionboxFocusController from "retrospring/controllers/questionbox_focus_controller";
import ReactionController from "retrospring/controllers/reaction_controller";

/**
* This module sets up Stimulus and our controllers
Expand Down Expand Up @@ -43,4 +44,5 @@ export default function (): void {
window['Stimulus'].register('share', ShareController);
window['Stimulus'].register('clipboard', ClipboardController);
window['Stimulus'].register('questionbox-focus', QuestionboxFocusController);
window['Stimulus'].register('reaction', ReactionController);
}
14 changes: 10 additions & 4 deletions app/views/reactions/_create.html.haml
Original file line number Diff line number Diff line change
@@ -1,13 +1,19 @@
- if type == "Answer"
= button_to create_reactions_path(id: target.id, username: target.user.screen_name),
form: { class: "d-inline-block", id: "reaction-#{type}-#{target.id}" },
class: "btn btn-link answerbox__action smile" do
form: { class: "d-inline-block",
id: "reaction-#{type}-#{target.id}",
data: { controller: :reaction, action: "turbo:submit-start->reaction#disable turbo:submit-end->reaction#enable" } },
class: "btn btn-link answerbox__action smile",
data: { reaction_target: :button } do
%i.fa.fa-fw.fa-smile-o
%span= target.smile_count

- if type == "Comment"
= button_to create_comment_reactions_path(id: target.id, username: target.user.screen_name),
form: { class: "d-inline-block", id: "reaction-#{type}-#{target.id}" },
class: "btn btn-link answerbox__action smile" do
form: { class: "d-inline-block",
id: "reaction-#{type}-#{target.id}",
data: { controller: :reaction, action: "turbo:submit-start->reaction#disable turbo:submit-end->reaction#enable" } },
class: "btn btn-link answerbox__action smile",
data: { reaction_target: :button } do
%i.fa.fa-fw.fa-smile-o
%span= target.smile_count
14 changes: 10 additions & 4 deletions app/views/reactions/_destroy.html.haml
Original file line number Diff line number Diff line change
@@ -1,15 +1,21 @@
- if type == "Answer"
= button_to destroy_reactions_path(id: target.id, username: target.user.screen_name),
method: :delete,
form: { class: "d-inline-block", id: "reaction-#{type}-#{target.id}" },
class: "btn btn-link answerbox__action unsmile" do
form: { class: "d-inline-block",
id: "reaction-#{type}-#{target.id}",
data: { controller: :reaction, action: "turbo:submit-start->reaction#disable turbo:submit-end->reaction#enable" } },
class: "btn btn-link answerbox__action unsmile",
data: { reaction_target: :button } do
%i.fa.fa-fw.fa-smile-o
%span= target.smile_count

- if type == "Comment"
= button_to destroy_comment_reactions_path(id: target.id, username: target.user.screen_name),
method: :delete,
form: { class: "d-inline-block", id: "reaction-#{type}-#{target.id}" },
class: "btn btn-link answerbox__action unsmile" do
form: { class: "d-inline-block",
id: "reaction-#{type}-#{target.id}",
data: { controller: :reaction, action: "turbo:submit-start->reaction#disable turbo:submit-end->reaction#enable" } },
class: "btn btn-link answerbox__action unsmile",
data: { reaction_target: :button } do
%i.fa.fa-fw.fa-smile-o
%span= target.smile_count