is NetPeer.Send thread safe?

[friuns2]

hello is NetPeer.Send thread safe can i do like that?

public NetPeer peer;
     public void OnMessage(NetDataReader br)
        {
            Task.Run(() =>
            {
                var id = br.GetInt();
               ..............
                peer.Send(nw, SendOptions.ReliableOrdered);
            });
        }

[RevenantX]

Hi! No, NetPeer.Send is not thread safe (especially for fragmented messages). But if you need i can make it thread safe (it almost done))

[friuns2]

cool thanks!

[pax83]

I plane to move my server from lidgren3 to LiteNetLib. I have rooms realization and each room has own thread. If it is not thread-safe, then in what thread should I use to send messages?

[RevenantX]

@pax83 i will make thread safe send fix soon.
Use any thread but just one) Also you can do this using locks for now.

public void MyThreadSafeSend(byte[] data)
{
    lock(this)
    {
        netPeer.Send(...)
    }
}

[RevenantX]

Fixed in next version branch (packetprocessor)

[RevenantX]

@friuns2 merged into main branch.

[pha3z]

Fixed in next version branch (packetprocessor)

Are you saying that NetPacketProcessor is threadsafe, but the rest of the API is not?

So I must use NetPacketProcessor.Send(Peer, Packet, DeliveryMethod) and not peer.send() if I want to call it from multiple threads?

[RevenantX]

@pha3z this fixed in master branch for now. (merged from packetprocessor branch, not class)

[sebas77]

Hi, sorry resuming this post (blame google for it :D).

is NetPeer.Send now thread safe? From what I can see from the code, it doesn't seem like