Unify caching offerings and updating update timestamp #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
added
the
refactor
tonidero
force-pushed
the
unify-offerings-cache-to-cache-timestamp
branch
from
9550a4d
to
cc3e3f0
Compare
tonidero
force-pushed
the
unify-offerings-cache-to-cache-timestamp
branch
from
cc3e3f0
to
e5dd1e2
Compare
tonidero
commented
Aug 23, 2023
| @@ -407,62 +407,6 @@ class OfferingsManagerTest { | |||
| verify(exactly = 1) { cache.clearOfferingsCacheTimestamp() } | |||
| } | |||
|
|
|||
| @Test | |||
| fun `getOfferings marks offerings cache timestamp upon success`() { | |||
There was a problem hiding this comment.
These tests don't make sense now, and we have other tests verifying we are caching offerings.
Codecov Report
@@ Coverage Diff @@
## main #1206 +/- ##
==========================================
+ Coverage 85.87% 85.89% +0.01%
==========================================
Files 183 183
Lines 6252 6251 -1
Branches 910 910
==========================================
Hits 5369 5369
+ Misses 537 536 -1
Partials 346 346
|
NachoSoto
approved these changes
Aug 23, 2023
This was referenced Aug 30, 2023
tonidero
pushed a commit
that referenced
this pull request
Aug 31, 2023
**This is an automatic release.** ### Dependency Updates * Bump fastlane-plugin-revenuecat_internal from `b2108fb` to `a297205` (#1210) via dependabot[bot] (@dependabot[bot]) ### Other Changes * Rename `queue` initiation source to `unsynced_active_purchases` (#1214) via Toni Rico (@tonidero) * Send `initiation_source` in post receipt requests (#1212) via Toni Rico (@tonidero) * CustomEntitlementComputation: Add `restorePurchases` (#1211) via Toni Rico (@tonidero) * Unify caching offerings and updating update timestamp (#1206) via Toni Rico (@tonidero) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unifies caching offerings and updating the offerings cache timestamp to simplify things, as suggested in #1204 (comment)