Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds kotlinx serialization #1221

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Adds kotlinx serialization #1221

merged 1 commit into from
Sep 6, 2023

Conversation

vegaro
Copy link
Contributor

@vegaro vegaro commented Sep 5, 2023 •
edited

Adds kotlinx serialization dependency

@vegaro vegaro changed the title Adds kotlinx serialization [WIP] Adds kotlinx serialization Sep 5, 2023
@vegaro vegaro added the feat A new feature label Sep 5, 2023
@vegaro vegaro force-pushed the cesar/pwl-148-sdk-parse-offerings-response-paywall-data-and-add_2 branch from 6b64273 to aa4ca60 Compare September 6, 2023 08:27
@vegaro vegaro changed the title [WIP] Adds kotlinx serialization Adds kotlinx serialization Sep 6, 2023
@vegaro vegaro added the dependencies Changes on external dependencies label Sep 6, 2023
@vegaro vegaro marked this pull request as ready for review September 6, 2023 08:27
@vegaro vegaro requested a review from a team September 6, 2023 08:27
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

❗ No coverage uploaded for pull request base (paywalls@c170c6d). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@             Coverage Diff             @@
##             paywalls    #1221   +/-   ##
===========================================
  Coverage            ?   85.25%           
===========================================
  Files               ?      186           
  Lines               ?     6319           
  Branches            ?      911           
===========================================
  Hits                ?     5387           
  Misses              ?      586           
  Partials            ?      346

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tonidero
tonidero approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Also, another reason to consider updating Kotlin in the next major, since that will unblock a bunch of updates

@vegaro vegaro merged commit a1987db into paywalls Sep 6, 2023
7 checks passed
@vegaro vegaro deleted the cesar/pwl-148-sdk-parse-offerings-response-paywall-data-and-add_2 branch September 6, 2023 10:56
This was referenced Oct 16, 2023
Closed
Closed
tonidero pushed a commit that referenced this pull request Oct 31, 2023
@vegaro @tonidero
Adds kotlinx serialization (#1221)
a58e902
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonidero tonidero tonidero approved these changes

Assignees
No one assigned
Labels
dependencies Changes on external dependencies feat A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vegaro @tonidero