Paywalls: Organize files into packages #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
added
refactor
tonidero
commented
Sep 12, 2023
| @@ -11,7 +11,7 @@ import coil.compose.AsyncImage | |||
| import coil.disk.DiskCache | |||
|
|
|||
| @Composable | |||
| fun RemoteImage( | |||
| internal fun RemoteImage( | |||
There was a problem hiding this comment.
I took the chance to make this internal
|
|
||
| import android.util.Log | ||
|
|
||
| object Logger { | ||
| internal object Logger { |
There was a problem hiding this comment.
Same here, making it internal
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## paywalls #1241 +/- ##
===========================================
Coverage ? 85.10%
===========================================
Files ? 187
Lines ? 6346
Branches ? 923
===========================================
Hits ? 5401
Misses ? 598
Partials ? 347 ☔ View full report in Codecov by Sentry. |
vegaro
approved these changes
Sep 12, 2023
This was referenced Oct 16, 2023
tonidero
added a commit
that referenced
this pull request
Oct 31, 2023
### Description This PR reorganizes the the new RevenueCatUI module files. The packages are: - `composables`: For generic composables used in multiple UI locations - `helpers`: Generic helpers - `extensions`: Extensions for existing classes - `data`: Data used to drive the UI and view model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reorganizes the the new RevenueCatUI module files. The packages are:
composables: For generic composables used in multiple UI locationshelpers: Generic helpersextensions: Extensions for existing classesdata: Data used to drive the UI and view model