Hook up purchasing listeners #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vegaro
force-pushed
the
cesar/pwl-197-add-support-for-purchasing
branch
from
43add43
to
5be58d1
Compare
vegaro
commented
Sep 12, 2023
| @@ -14,7 +14,8 @@ import com.revenuecat.purchases.ui.revenuecatui.templates.Template2 | |||
| @Composable | |||
| internal fun InternalPaywallView( | |||
| offering: Offering? = null, | |||
| viewModel: PaywallViewModel = getPaywallViewModel(offering = offering), | |||
| listener: PaywallViewListener? = null, | |||
| viewModel: PaywallViewModel = getPaywallViewModel(offering = offering, listener = listener), | |||
There was a problem hiding this comment.
@tonidero can you please check this out? I am not sure this approach is okay
There was a problem hiding this comment.
I think this looks ok. One option if we're worried about passing more parameters is to pass the entire PaywallViewOptions object instead of each of these separately.
There was a problem hiding this comment.
that might make sense yes... I think we can keep these three and if the number of parameters starts growing too much we can do that
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## paywalls #1243 +/- ##
===========================================
Coverage ? 85.48%
===========================================
Files ? 187
Lines ? 6346
Branches ? 923
===========================================
Hits ? 5425
Misses ? 564
Partials ? 357 ☔ View full report in Codecov by Sentry. |
vegaro
changed the title
tonidero
approved these changes
Sep 13, 2023
This was referenced Oct 16, 2023
tonidero
pushed a commit
that referenced
this pull request
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds purchasing listener to view model so we can display state in the UI