Avoid creating threads when dispatching tasks #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
commented
Nov 24, 2023
purchases/src/main/kotlin/com/revenuecat/purchases/common/Dispatcher.kt
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1496 +/- ##
=======================================
Coverage 84.12% 84.13%
=======================================
Files 215 215
Lines 7193 7197 +4
Branches 1016 1016
=======================================
+ Hits 6051 6055 +4
- Misses 741 742 +1
+ Partials 401 400 -1 ☔ View full report in Codecov by Sentry. |
vegaro
reviewed
Nov 24, 2023
| } catch (@Suppress("TooGenericExceptionCaught") e: Exception) { | ||
| errorLog("Exception running command: $e") | ||
| mainHandler?.post { | ||
| throw e.cause ?: e |
There was a problem hiding this comment.
can you explain this? why not just throw e?
There was a problem hiding this comment.
Probably not needed, I was mostly copying here what we had previously... In my tests, the cause was sometimes null, so I fallback to the original exception, but we could probably just propagate the original exception
There was a problem hiding this comment.
Yes, I am not sure why we were doing e.cause 🤔
vegaro
approved these changes
Nov 24, 2023
tonidero
pushed a commit
that referenced
this pull request
Nov 30, 2023
**This is an automatic release.** ### Bugfixes * Fix white line around buttons in Template 4 (#1499) via Cesar de la Vega (@vegaro) ### Performance Improvements * Avoid creating threads when dispatching tasks (#1496) via Toni Rico (@tonidero) ### Other Changes * Refactor QueryPurchasesUseCase and adds QueryPurchasesByTypeUseCase (#1495) via Cesar de la Vega (@vegaro) * Fixes on `update_snapshots_repo` (#1501) via Cesar de la Vega (@vegaro) * Fixes on generate_snapshots_RCUI lane (#1500) via Cesar de la Vega (@vegaro) * Fix integration tests (#1498) via Toni Rico (@tonidero) * Cleanup warnings in AcknowledgePurchaseUseCaseTest (#1497) via Cesar de la Vega (@vegaro) * Add AcknowledgePurchaseUseCase (#1492) via Cesar de la Vega (@vegaro) * Refactor findPurchaseInPurchaseHistory (#1493) via Cesar de la Vega (@vegaro) * ConsumePurchaseUseCase (#1487) via Cesar de la Vega (@vegaro) * Add retries with backoff and different treatment to SERVICE_UNAVAILABLE (#1490) via Cesar de la Vega (@vegaro) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were creating threads every time we added a task to the executor service. This shouldn't be a problem if tasks ended early and not too many tasks were in the queue, but it's not very efficient. This is another implementation to propagate exceptions to the main thread so they can be thrown and not swallowed when they happen on the thread pool.