Fix white line around buttons in Template 4 #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
reviewed
Nov 27, 2023
| Button( | ||
| modifier = modifier | ||
| .alpha(buttonAlpha) | ||
| .padding(1.dp) // Trick to prevent white line around the button border |
There was a problem hiding this comment.
I wonder if it would work with 1px instead of 1dp... You can convert pixels to dp with this I think: https://developer.android.com/reference/kotlin/androidx/compose/ui/unit/Density#(kotlin.Int).toDp()
tonidero
approved these changes
Nov 27, 2023
tonidero
pushed a commit
that referenced
this pull request
Nov 30, 2023
**This is an automatic release.** ### Bugfixes * Fix white line around buttons in Template 4 (#1499) via Cesar de la Vega (@vegaro) ### Performance Improvements * Avoid creating threads when dispatching tasks (#1496) via Toni Rico (@tonidero) ### Other Changes * Refactor QueryPurchasesUseCase and adds QueryPurchasesByTypeUseCase (#1495) via Cesar de la Vega (@vegaro) * Fixes on `update_snapshots_repo` (#1501) via Cesar de la Vega (@vegaro) * Fixes on generate_snapshots_RCUI lane (#1500) via Cesar de la Vega (@vegaro) * Fix integration tests (#1498) via Toni Rico (@tonidero) * Cleanup warnings in AcknowledgePurchaseUseCaseTest (#1497) via Cesar de la Vega (@vegaro) * Add AcknowledgePurchaseUseCase (#1492) via Cesar de la Vega (@vegaro) * Refactor findPurchaseInPurchaseHistory (#1493) via Cesar de la Vega (@vegaro) * ConsumePurchaseUseCase (#1487) via Cesar de la Vega (@vegaro) * Add retries with backoff and different treatment to SERVICE_UNAVAILABLE (#1490) via Cesar de la Vega (@vegaro) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From:
To:
I fixed it by adding the border to the surrounding box and a very small padding to the button. I think the line comes originally from antialising.