Fix NullPointerException issues getting advertising id #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
tonidero
force-pushed
the
fix-google-ads-null-pointer-issues
branch
from
bc4a1bb
to
3ca41e4
Compare
matteinn
approved these changes
Jan 5, 2024
aboedo
approved these changes
Jan 5, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1550 +/- ##
==========================================
- Coverage 84.14% 84.08% -0.06%
==========================================
Files 218 218
Lines 7196 7201 +5
Branches 1007 1007
==========================================
Hits 6055 6055
- Misses 750 755 +5
Partials 391 391 ☔ View full report in Codecov by Sentry. |
vegaro
pushed a commit
that referenced
this pull request
Jan 11, 2024
**This is an automatic release.** ### Bugfixes * Fix NullPointerException issues getting advertising id (#1550) via Toni Rico (@tonidero) ### Dependency Updates * Bump fastlane from 2.218.0 to 2.219.0 (#1549) via dependabot[bot] (@dependabot[bot]) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
tonidero
added a commit
that referenced
this pull request
Jan 18, 2024
### Description We bumped the ad library version in #1550. However, that version of the library adds the `AD_ID` permission, forcing our customers to have it as well, which is not intended. This reverts that bump but keeps the null pointer exception handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was reported in #1548. I wasn't able to reproduce but from looking around, seems that an update to the the latest version of the library should fix it. However, the latest version is pretty old (from 1/2022). Just in case, I added a catch to that block of code with a log, so it doesn't crash.