Prevents uploading api-tester to maven #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
approved these changes
Jan 14, 2022
There was a problem hiding this comment.
Oops thanks! I followed https://www.notion.so/revenuecat/Android-Modularization-ac165aa9a3e74ee19a15b010dc974677. I see there's a note there about uploading to Maven that I guess I missed!
| } | ||
| } | ||
| compileOptions { | ||
| sourceCompatibility JavaVersion.VERSION_1_8 |
There was a problem hiding this comment.
Could these be defined as a variable here? Looks like it's currently repeated in several places.
There was a problem hiding this comment.
Good idea. We can create a base .gradle for api-tester, integration-tests, purchase-tester and purchase-tester-java!
There was a problem hiding this comment.
Going to merge this and open another PR for that change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were uploading the api-tester module to sonatype because the publishing plugin was being applied via
library.gradle