Creates a base-application.gradle #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #12565: Create base gradle file for applications. |
beylmk
reviewed
Jan 19, 2022
|
|
||
| android { | ||
| compileSdkVersion 29 | ||
| buildToolsVersion "30.0.3" | ||
|
|
||
| defaultConfig { | ||
| applicationId "com.revenuecat.purchases_sample" | ||
| minSdkVersion 26 |
There was a problem hiding this comment.
is this a diff minSdk for a reason?
There was a problem hiding this comment.
I don't know, I think it has a dependency that requires 26, but I am not sure
beylmk
reviewed
Jan 19, 2022
| defaultConfig { | ||
| applicationId "com.revenuecat.purchases_sample" | ||
| minSdkVersion 26 | ||
| targetSdkVersion 29 | ||
| targetSdkVersion compileVersion |
There was a problem hiding this comment.
we can just remove this now right?
beylmk
approved these changes
Jan 19, 2022
vegaro
deleted the
cesardelavega/sc-12565/create-base-gradle-file-for-applications
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a
base-application.gradleto remove duplicated configuration in the applications we have in the repository.Suggested by @NachoSoto in #445 (comment)