Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New headers for iOS & purchases-hybrid-common pod #46

Merged
merged 7 commits into from
May 28, 2020
Merged

Conversation

aboedo
Copy link
Member

@aboedo aboedo commented May 13, 2020

  • Adds new headers for iOS, for platformFlavor and platformFlavorVersion.
  • Updates purchasesHybridCommon to a pod instead of having all of the classes copied over.
  • removes purchases-hybrid-common download script.

Requirements:

  • PurchasesHybridCommon pod

@aboedo aboedo self-assigned this May 13, 2020
@aboedo aboedo changed the title New headers for iOS New headers for iOS & purchases-hybrid-common pod May 15, 2020
@aboedo aboedo marked this pull request as ready for review May 15, 2020 22:29
@aboedo aboedo requested a review from vegaro May 15, 2020 22:29
@aboedo aboedo removed the HOLD label May 19, 2020
@aboedo
Copy link
Member Author

aboedo commented May 19, 2020

hold removed //cc @vegaro

@@ -15,49 +15,64 @@ def parse_KV_file(file, separator='=')
if !File.exists? file_abs_path
return [];
end
pods_ary = []
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything here is autogenerated

Comment on lines +112 to +114
userDefaults:nil
platformFlavor:self.platformFlavor
platformFlavorVersion:self.platformFlavorVersion];
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actual changes for new headers here

@@ -15,8 +15,7 @@ Pod::Spec.new do |s|
s.source_files = 'Classes/**/*'
s.public_header_files = 'Classes/**/*.h'
s.dependency 'Flutter'
s.dependency 'Purchases', '~> 3.2.2'

s.dependency 'PurchasesHybridCommon', '1.1.0'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is how dependencies will be managed from now on, PurchasesHybridCommon already has a pointer to the Purchases version

@@ -1,48 +0,0 @@
#!/bin/sh
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no longer needed

Copy link
Contributor

@vegaro vegaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry it took so long

@aboedo aboedo merged commit 3ff5c45 into master May 28, 2020
@aboedo aboedo deleted the new_headers branch May 28, 2020 18:18
@vegaro vegaro mentioned this pull request Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants