release 1.3.0 #96
release 1.3.0 #96
Conversation
added new methods for attribution v2 and deprecated old ones
lib/transaction.dart
Outdated
| @@ -0,0 +1,24 @@ | |||
| class Transaction { | |||
| /// RevenueCat Id associated to the transaction. | |||
| final String revenuecatId; | |||
There was a problem hiding this comment.
I just realized the c is not capitalized in the Android and iOS class, and that the d is lowercase in Id 🤦
There was a problem hiding this comment.
I'm capitalizing the C, but the d in ID I'm not updating right now because it should match the original iOS code - once we update it in purchases-ios, we can update it here
There was a problem hiding this comment.
actually, it's a little more problematic - it's capitalized here:
https://github.com/RevenueCat/purchases-hybrid-common/blob/develop/ios/PurchasesHybridCommon/PurchasesHybridCommon/RCTransaction%2BHybridAdditions.m#L17
and not here:
https://github.com/RevenueCat/purchases-hybrid-common/blob/develop/android/src/main/java/com/revenuecat/purchases/common/mappers/TransactionMapper.kt#L7
so we'll need another patch release to fix it, otherwise mappers won't work.
I'll take care of it
There was a problem hiding this comment.
okay, tested and working with common 1.4.2 RevenueCat/purchases-hybrid-common#55
This PR will need to bump the version number once the hybrid-common release is out, though. adding a hold until then.
|
@vegaro this is ready for another pass |
1.3.0
addAttributionin favor ofsetAdjustId,setAppsflyerId,setFbAnonymousId,setMparticleId.setOnesignalIdsetMediaSource,setCampaign,setAdGroup,setAd,setKeyword,setCreative, andcollectDeviceIdentifiersFixes 404 marking attributes as synced purchases-android#184
purchases-hybrid-commonto 1.4.2 Changelog herepurchases-iosto 3.7.1 Changelog herepurchases-androidto 3.5.0 Changelog here