Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x.x - add s.deprecated_in_favor_of to reduce confusion when v4 not installed #1552

Merged
merged 1 commit into from Apr 29, 2022

Conversation

joshdholtz
Copy link
Contributor

Motivation

This question comes up quite often on why v4 has was not installed when running pod install or pod update and its because v4 is associated with the pod name RevenueCat and not Purchases

Description

Sets deprecated and deprecated_in_favor_of in the v3 Purchases podspec that will output the RevenueCat in now favored

Screen Shot 2022-04-29 at 10 39 18 AM

@joshdholtz joshdholtz requested review from codykerns and a team April 29, 2022 15:42
@joshdholtz joshdholtz changed the title 3.x.x - add deprecate_in_favor_of to reduce confusion when v4 not installed 3.x.x - add s.deprecated_in_favor_of to reduce confusion when v4 not installed Apr 29, 2022
Copy link
Contributor

@NachoSoto NachoSoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesssss 😍😍😍

@NachoSoto
Copy link
Contributor

I think this will need a new release, right?

@joshdholtz
Copy link
Contributor Author

@NachoSoto Yup yup, it will! 😊

@joshdholtz joshdholtz merged commit 9b10204 into release/3.x.x Apr 29, 2022
@joshdholtz joshdholtz deleted the cocoapods-add-deprecate_in_favor_of branch April 29, 2022 19:04
@joshdholtz joshdholtz mentioned this pull request Apr 29, 2022
@aboedo
Copy link
Member

aboedo commented May 3, 2022

awesome 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants