Release/3.14.2 #1553
Merged
Release/3.14.2 #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
approved these changes
Apr 29, 2022
joshdholtz
force-pushed
the
release/3.14.2
branch
from
2a9911c
to
e8589f7
Compare
|
@NachoSoto The Carthage integration tests are failing because of reasons that I don't think are super important but 🤷♂️ Is this still okay to merge and release? 🙃 |
|
What's the failure? |
|
@NachoSoto It looks like its checking out |
|
Looking at that now it seems wrong. The new version correctly replaces |
joshdholtz
force-pushed
the
release/3.14.2
branch
from
59b4f93
to
d6c85c2
Compare
|
@NachoSoto Looks like we gucci now! |
NachoSoto
approved these changes
Apr 29, 2022
| git "./purchases-root" "CARTHAGE_INTEGRATION_TESTS_GIT_COMMIT" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purchasespod in favor ofRevenueCat3.x.x - add
s.deprecated_in_favor_ofto reduce confusion when v4 not installed #1552