`Offline Entitlements`: create `CustomerInfo` from offline entitlements #2358

NachoSoto · 2023-03-21T19:28:00Z

Based on #2352.
Depends on #2351 and #2365.

NachoSoto · 2023-03-21T19:28:19Z

Sources/OfflineEntitlements/CustomerInfo+OfflineEntitlements.swift

+//
+//      https://opensource.org/licenses/MIT
+//
+//  CustomerInfo+OfflineEntitlements.swift


Started this @aboedo

Tests/UnitTests/OfflineEntitlements/CustomerInfoOfflineEntitlementsTest.swift

Sources/OfflineEntitlements/CustomerInfo+OfflineEntitlements.swift

NachoSoto · 2023-03-23T19:29:12Z

Tests/StoreKitUnitTests/OfflineEntitlements/CustomerInfoOfflineEntitlementsStoreKitTest.swift

+        expect(info.managementURL).to(beNil())
+        expect(info.originalAppUserId).toNot(beEmpty())
+        expect(info.originalAppUserId) == Self.userID
+        expect(info.originalApplicationVersion) == SystemInfo.buildVersion


Is this correct?

NachoSoto · 2023-03-23T20:14:10Z

This is ready for review.

codecov · 2023-03-23T20:24:30Z

Codecov Report

Merging #2358 (72033e0) into main (06f80c3) will decrease coverage by 0.04%.
The diff coverage is 75.59%.

❗ Current head 72033e0 differs from pull request most recent head 39b0b5e. Consider uploading reports for the commit 39b0b5e to get more accurate results

@@            Coverage Diff             @@
##             main    #2358      +/-   ##
==========================================
- Coverage   86.64%   86.61%   -0.04%     
==========================================
  Files         195      198       +3     
  Lines       13056    13181     +125     
==========================================
+ Hits        11313    11417     +104     
- Misses       1743     1764      +21

Impacted Files	Coverage Δ
...OfflineEntitlements/PurchasedProductsFetcher.swift	`0.00% <0.00%> (ø)`
...s/Logging/Strings/OfflineEntitlementsStrings.swift	`71.42% <33.33%> (-28.58%)`	⬇️
...rces/OfflineEntitlements/PurchasedSK2Product.swift	`92.85% <92.85%> (ø)`
.../FoundationExtensions/JSONDecoder+Extensions.swift	`68.18% <100.00%> (+1.91%)`	⬆️
...es/Networking/Responses/CustomerInfoResponse.swift	`100.00% <100.00%> (ø)`
...ntitlements/CustomerInfo+OfflineEntitlements.swift	`100.00% <100.00%> (ø)`

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

…ntitlementMappingResponse`

vegaro · 2023-03-23T23:57:34Z

Sources/OfflineEntitlements/PurchasedSK2Product.swift

+
+    let productIdentifier: String
+    let subscription: CustomerInfoResponse.Subscription
+    let entitlement: CustomerInfoResponse.Entitlement


What happens if the product is not associated with any entitlement, but is has been purchased? Will it show in the subscriptions section of CustomerInfo?

tonidero

LGTM! @vegaro is working on the android part so he probably should review it as well.

tonidero · 2023-03-24T07:01:34Z

Sources/OfflineEntitlements/PurchasedProductsFetcher.swift

+
+/// A type that can fetch purchased products from StoreKit 2.
+@available(iOS 15.0, tvOS 15.0, watchOS 8.0, macOS 12.0, *)
+class PurchasedProductsFetcher {


Do we need to add tests to this class? (Not sure how difficult it is to mock StoreKit transactions in swift)

We can sort of mock transactions by making purchases. We could mock StoreKit.Transaction.currentEntitlements, but then we're not really testing anything.
The worry I had is that this might be flaky because StoreKit.Transaction.currentEntitlements might return stuff from other tests, but let me see if I can write a test that passes consistently.

Tests/StoreKitUnitTests/TestHelpers/StoreKitConfigTestCase+Extensions.swift

Sources/OfflineEntitlements/CustomerInfo+OfflineEntitlements.swift

Co-authored-by: Toni Rico <antonio.rico.diez@revenuecat.com>

Sources/OfflineEntitlements/PurchasedSK2Product.swift

Broken by #2358. This is the same as apple/swift#58099 Even though `OfflineEntitlementsStrings` isn't available on iOS 12, it can't contain types that aren't available at runtime on iOS 12.

@NachoSoto

### New Features * New `ErrorCode.signatureVerificationFailed` which will be used for an upcoming feature ### Bugfixes * `Purchases.deinit`: don't reset `Purchases.proxyURL` (#2346) via NachoSoto (@NachoSoto) <details> <summary><b>Other Changes</b></summary> * Introduced `Configuration.EntitlementVerificationMode` and `VerificationResult` (#2277) via NachoSoto (@NachoSoto) * `PurchasesDiagnostics`: added step to verify signature verification (#2267) via NachoSoto (@NachoSoto) * `HTTPClient`: added signature validation and introduced `ErrorCode.signatureVerificationFailed` (#2272) via NachoSoto (@NachoSoto) * `ETagManager`: don't use ETags if response verification failed (#2347) via NachoSoto (@NachoSoto) * `Integration Tests`: removed `@preconcurrency import` (#2464) via NachoSoto (@NachoSoto) * Clean up: moved `ReceiptParserTests-Info.plist` out of root (#2460) via NachoSoto (@NachoSoto) * Update `CHANGELOG` (#2461) via NachoSoto (@NachoSoto) * Update `SwiftSnapshotTesting` (#2453) via NachoSoto (@NachoSoto) * Fixed docs (#2432) via Kaunteya Suryawanshi (@kaunteya) * Remove unnecessary line break (#2435) via Andy Boedo (@aboedo) * `ProductEntitlementMapping`: enabled entitlement mapping fetching (#2425) via NachoSoto (@NachoSoto) * `BackendPostReceiptDataTests`: increased timeout to fix flaky test (#2426) via NachoSoto (@NachoSoto) * Updated requirements to drop Xcode 13.x support (#2419) via NachoSoto (@NachoSoto) * `Integration Tests`: fixed flaky errors when loading offerings (#2420) via NachoSoto (@NachoSoto) * `PurchaseTester`: fixed compilation for `internal` entitlement verification (#2417) via NachoSoto (@NachoSoto) * `ETagManager`/`HTTPClient`: sending new `X-RC-Last-Refresh-Time` header (#2373) via NachoSoto (@NachoSoto) * `ETagManager`: don't send validation time if not present (#2490) via NachoSoto (@NachoSoto) * SwiftUI Sample Project: Refactor Package terms method to a computed property (#2405) via Joseph Kokenge (@JOyo246) * Clean up v3 load shedder integration tests (#2402) via Andy Boedo (@aboedo) * Fix iOS 12 compilation (#2394) via NachoSoto (@NachoSoto) * Added new `VerificationResult.verifiedOnDevice` (#2379) via NachoSoto (@NachoSoto) * `PurchaseTester`: fix memory leaks (#2392) via Keita Watanabe (@kitwtnb) * Integration tests: add scheduled job (#2389) via Andy Boedo (@aboedo) * Add lane for running iOS v3 load shedder integration tests (#2388) via Andy Boedo (@aboedo) * iOS v3 load shedder integration tests (#2387) via Andy Boedo (@aboedo) * `Offline Entitlements`: created `LoadShedderIntegrationTests` (#2362) via NachoSoto (@NachoSoto) * Purchases.configure: log warning if attempting to use a static appUserID (#2385) via Mark Villacampa (@MarkVillacampa) * `SubscriberAttributesManagerIntegrationTests`: fixed flaky failures (#2381) via NachoSoto (@NachoSoto) * `@DefaultDecodable.Now`: fixed flaky test (#2374) via NachoSoto (@NachoSoto) * `PurchaseTesterSwiftUI`: fixed iOS compilation (#2376) via NachoSoto (@NachoSoto) * `SubscriberAttributesManagerIntegrationTests`: fixed potential race condition (#2380) via NachoSoto (@NachoSoto) * `Offline Entitlements`: create `CustomerInfo` from offline entitlements (#2358) via NachoSoto (@NachoSoto) * Added `@DefaultDecodable.Now` (#2372) via NachoSoto (@NachoSoto) * `HTTPClient`: debug log when performing redirects (#2371) via NachoSoto (@NachoSoto) * `HTTPClient`: new flag to force server errors (#2370) via NachoSoto (@NachoSoto) * `OfferingsManager`: fixed Xcode 13.x build (#2369) via NachoSoto (@NachoSoto) * `Offline Entitlements`: store `ProductEntitlementMapping` in cache (#2355) via NachoSoto (@NachoSoto) * `Offline Entitlements`: added support for fetching `ProductEntitlementMappingResponse` in `OfflineEntitlementsAPI` (#2353) via NachoSoto (@NachoSoto) * `Offline Entitlements`: created `ProductEntitlementMapping` (#2365) via NachoSoto (@NachoSoto) * Implemented `NetworkError.isServerDown` (#2367) via NachoSoto (@NachoSoto) * `ETagManager`: added test for 304 responses with no etag (#2360) via NachoSoto (@NachoSoto) * `TestLogHandler`: increased default capacity (#2357) via NachoSoto (@NachoSoto) * `OfferingsManager`: moved log to common method to remove hardcoded string (#2363) via NachoSoto (@NachoSoto) * `Offline Entitlements`: created `ProductEntitlementMappingResponse` (#2351) via NachoSoto (@NachoSoto) * `HTTPClient`: added test for 2xx response for request with etag (#2361) via NachoSoto (@NachoSoto) * `PurchaseTesterSwiftUI` improvements (#2345) via NachoSoto (@NachoSoto) * `ConfigureStrings`: fixed double-space typo (#2344) via NachoSoto (@NachoSoto) * `ETagManagerTests`: fixed tests on iOS 12 (#2349) via NachoSoto (@NachoSoto) * `DeviceCache`: simplified constructor (#2354) via NachoSoto (@NachoSoto) * `Trusted Entitlements`: changed all APIs to `internal` (#2350) via NachoSoto (@NachoSoto) * `VerificationResult.notRequested`: removed caching reference (#2337) via NachoSoto (@NachoSoto) * Finished signature verification `HTTPClient` tests (#2333) via NachoSoto (@NachoSoto) * `Configuration.Builder.with(entitlementVerificationMode:)`: improved documentation (#2334) via NachoSoto (@NachoSoto) * `ETagManager`: don't ignore failed etags with `Signing.VerificationMode.informational` (#2331) via NachoSoto (@NachoSoto) * `IdentityManager`: clear `ETagManager` and `DeviceCache` if verification is enabled but cached `CustomerInfo` is not (#2330) via NachoSoto (@NachoSoto) * Made `Configuration.EntitlementVerificationMode.enforced` unavailable (#2329) via NachoSoto (@NachoSoto) * Refactor: reorganized files in new Security and Misc folders (#2326) via NachoSoto (@NachoSoto) * `CustomerInfo`: use same grace period logic for active subscriptions (#2327) via NachoSoto (@NachoSoto) * `HTTPClient`: don't verify 4xx/5xx responses (#2322) via NachoSoto (@NachoSoto) * `EntitlementInfo`: request date is not optional (#2325) via NachoSoto (@NachoSoto) * `CustomerInfo`: removed `entitlementVerification` (#2320) via NachoSoto (@NachoSoto) * Renamed `VerificationResult.notVerified` to `.notRequested` (#2321) via NachoSoto (@NachoSoto) * `EntitlementInfo`: add a grace period limit to outdated entitlements (#2288) via NachoSoto (@NachoSoto) * Update `CustomerInfo.requestDate` from 304 responses (#2310) via NachoSoto (@NachoSoto) * `Signing`: added request time & eTag to signature verification (#2309) via NachoSoto (@NachoSoto) * `HTTPClient`: changed header search to be case-insensitive (#2308) via NachoSoto (@NachoSoto) * `HTTPClient`: automatically add `nonce` based on `HTTPRequest.Path` (#2286) via NachoSoto (@NachoSoto) * `PurchaseTester`: added ability to reload `CustomerInfo` with a custom `CacheFetchPolicy` (#2312) via NachoSoto (@NachoSoto) * Fix issue where underlying error information for product fetch errors was not printed in log. (#2281) via Chris Vasselli (@chrisvasselli) * `PurchaseTester`: added ability to set `Configuration.EntitlementVerificationMode` (#2290) via NachoSoto (@NachoSoto) * SwiftUI: Paywall View should respond to changes on the UserView model (#2297) via ConfusedVorlon (@ConfusedVorlon) * Deprecate `usesStoreKit2IfAvailable` (#2293) via Andy Boedo (@aboedo) * `Signing`: updated to use production public key (#2274) via NachoSoto (@NachoSoto) </details> --------- Co-authored-by: RCGitBot <dev+RCGitBot@revenuecat.com>

@NachoSoto

### New Features * New `ErrorCode.signatureVerificationFailed` which will be used for an upcoming feature ### Bugfixes * `Purchases.deinit`: don't reset `Purchases.proxyURL` (RevenueCat#2346) via NachoSoto (@NachoSoto) <details> <summary><b>Other Changes</b></summary> * Introduced `Configuration.EntitlementVerificationMode` and `VerificationResult` (RevenueCat#2277) via NachoSoto (@NachoSoto) * `PurchasesDiagnostics`: added step to verify signature verification (RevenueCat#2267) via NachoSoto (@NachoSoto) * `HTTPClient`: added signature validation and introduced `ErrorCode.signatureVerificationFailed` (RevenueCat#2272) via NachoSoto (@NachoSoto) * `ETagManager`: don't use ETags if response verification failed (RevenueCat#2347) via NachoSoto (@NachoSoto) * `Integration Tests`: removed `@preconcurrency import` (RevenueCat#2464) via NachoSoto (@NachoSoto) * Clean up: moved `ReceiptParserTests-Info.plist` out of root (RevenueCat#2460) via NachoSoto (@NachoSoto) * Update `CHANGELOG` (RevenueCat#2461) via NachoSoto (@NachoSoto) * Update `SwiftSnapshotTesting` (RevenueCat#2453) via NachoSoto (@NachoSoto) * Fixed docs (RevenueCat#2432) via Kaunteya Suryawanshi (@kaunteya) * Remove unnecessary line break (RevenueCat#2435) via Andy Boedo (@aboedo) * `ProductEntitlementMapping`: enabled entitlement mapping fetching (RevenueCat#2425) via NachoSoto (@NachoSoto) * `BackendPostReceiptDataTests`: increased timeout to fix flaky test (RevenueCat#2426) via NachoSoto (@NachoSoto) * Updated requirements to drop Xcode 13.x support (RevenueCat#2419) via NachoSoto (@NachoSoto) * `Integration Tests`: fixed flaky errors when loading offerings (RevenueCat#2420) via NachoSoto (@NachoSoto) * `PurchaseTester`: fixed compilation for `internal` entitlement verification (RevenueCat#2417) via NachoSoto (@NachoSoto) * `ETagManager`/`HTTPClient`: sending new `X-RC-Last-Refresh-Time` header (RevenueCat#2373) via NachoSoto (@NachoSoto) * `ETagManager`: don't send validation time if not present (RevenueCat#2490) via NachoSoto (@NachoSoto) * SwiftUI Sample Project: Refactor Package terms method to a computed property (RevenueCat#2405) via Joseph Kokenge (@JOyo246) * Clean up v3 load shedder integration tests (RevenueCat#2402) via Andy Boedo (@aboedo) * Fix iOS 12 compilation (RevenueCat#2394) via NachoSoto (@NachoSoto) * Added new `VerificationResult.verifiedOnDevice` (RevenueCat#2379) via NachoSoto (@NachoSoto) * `PurchaseTester`: fix memory leaks (RevenueCat#2392) via Keita Watanabe (@kitwtnb) * Integration tests: add scheduled job (RevenueCat#2389) via Andy Boedo (@aboedo) * Add lane for running iOS v3 load shedder integration tests (RevenueCat#2388) via Andy Boedo (@aboedo) * iOS v3 load shedder integration tests (RevenueCat#2387) via Andy Boedo (@aboedo) * `Offline Entitlements`: created `LoadShedderIntegrationTests` (RevenueCat#2362) via NachoSoto (@NachoSoto) * Purchases.configure: log warning if attempting to use a static appUserID (RevenueCat#2385) via Mark Villacampa (@MarkVillacampa) * `SubscriberAttributesManagerIntegrationTests`: fixed flaky failures (RevenueCat#2381) via NachoSoto (@NachoSoto) * `@DefaultDecodable.Now`: fixed flaky test (RevenueCat#2374) via NachoSoto (@NachoSoto) * `PurchaseTesterSwiftUI`: fixed iOS compilation (RevenueCat#2376) via NachoSoto (@NachoSoto) * `SubscriberAttributesManagerIntegrationTests`: fixed potential race condition (RevenueCat#2380) via NachoSoto (@NachoSoto) * `Offline Entitlements`: create `CustomerInfo` from offline entitlements (RevenueCat#2358) via NachoSoto (@NachoSoto) * Added `@DefaultDecodable.Now` (RevenueCat#2372) via NachoSoto (@NachoSoto) * `HTTPClient`: debug log when performing redirects (RevenueCat#2371) via NachoSoto (@NachoSoto) * `HTTPClient`: new flag to force server errors (RevenueCat#2370) via NachoSoto (@NachoSoto) * `OfferingsManager`: fixed Xcode 13.x build (RevenueCat#2369) via NachoSoto (@NachoSoto) * `Offline Entitlements`: store `ProductEntitlementMapping` in cache (RevenueCat#2355) via NachoSoto (@NachoSoto) * `Offline Entitlements`: added support for fetching `ProductEntitlementMappingResponse` in `OfflineEntitlementsAPI` (RevenueCat#2353) via NachoSoto (@NachoSoto) * `Offline Entitlements`: created `ProductEntitlementMapping` (RevenueCat#2365) via NachoSoto (@NachoSoto) * Implemented `NetworkError.isServerDown` (RevenueCat#2367) via NachoSoto (@NachoSoto) * `ETagManager`: added test for 304 responses with no etag (RevenueCat#2360) via NachoSoto (@NachoSoto) * `TestLogHandler`: increased default capacity (RevenueCat#2357) via NachoSoto (@NachoSoto) * `OfferingsManager`: moved log to common method to remove hardcoded string (RevenueCat#2363) via NachoSoto (@NachoSoto) * `Offline Entitlements`: created `ProductEntitlementMappingResponse` (RevenueCat#2351) via NachoSoto (@NachoSoto) * `HTTPClient`: added test for 2xx response for request with etag (RevenueCat#2361) via NachoSoto (@NachoSoto) * `PurchaseTesterSwiftUI` improvements (RevenueCat#2345) via NachoSoto (@NachoSoto) * `ConfigureStrings`: fixed double-space typo (RevenueCat#2344) via NachoSoto (@NachoSoto) * `ETagManagerTests`: fixed tests on iOS 12 (RevenueCat#2349) via NachoSoto (@NachoSoto) * `DeviceCache`: simplified constructor (RevenueCat#2354) via NachoSoto (@NachoSoto) * `Trusted Entitlements`: changed all APIs to `internal` (RevenueCat#2350) via NachoSoto (@NachoSoto) * `VerificationResult.notRequested`: removed caching reference (RevenueCat#2337) via NachoSoto (@NachoSoto) * Finished signature verification `HTTPClient` tests (RevenueCat#2333) via NachoSoto (@NachoSoto) * `Configuration.Builder.with(entitlementVerificationMode:)`: improved documentation (RevenueCat#2334) via NachoSoto (@NachoSoto) * `ETagManager`: don't ignore failed etags with `Signing.VerificationMode.informational` (RevenueCat#2331) via NachoSoto (@NachoSoto) * `IdentityManager`: clear `ETagManager` and `DeviceCache` if verification is enabled but cached `CustomerInfo` is not (RevenueCat#2330) via NachoSoto (@NachoSoto) * Made `Configuration.EntitlementVerificationMode.enforced` unavailable (RevenueCat#2329) via NachoSoto (@NachoSoto) * Refactor: reorganized files in new Security and Misc folders (RevenueCat#2326) via NachoSoto (@NachoSoto) * `CustomerInfo`: use same grace period logic for active subscriptions (RevenueCat#2327) via NachoSoto (@NachoSoto) * `HTTPClient`: don't verify 4xx/5xx responses (RevenueCat#2322) via NachoSoto (@NachoSoto) * `EntitlementInfo`: request date is not optional (RevenueCat#2325) via NachoSoto (@NachoSoto) * `CustomerInfo`: removed `entitlementVerification` (RevenueCat#2320) via NachoSoto (@NachoSoto) * Renamed `VerificationResult.notVerified` to `.notRequested` (RevenueCat#2321) via NachoSoto (@NachoSoto) * `EntitlementInfo`: add a grace period limit to outdated entitlements (RevenueCat#2288) via NachoSoto (@NachoSoto) * Update `CustomerInfo.requestDate` from 304 responses (RevenueCat#2310) via NachoSoto (@NachoSoto) * `Signing`: added request time & eTag to signature verification (RevenueCat#2309) via NachoSoto (@NachoSoto) * `HTTPClient`: changed header search to be case-insensitive (RevenueCat#2308) via NachoSoto (@NachoSoto) * `HTTPClient`: automatically add `nonce` based on `HTTPRequest.Path` (RevenueCat#2286) via NachoSoto (@NachoSoto) * `PurchaseTester`: added ability to reload `CustomerInfo` with a custom `CacheFetchPolicy` (RevenueCat#2312) via NachoSoto (@NachoSoto) * Fix issue where underlying error information for product fetch errors was not printed in log. (RevenueCat#2281) via Chris Vasselli (@chrisvasselli) * `PurchaseTester`: added ability to set `Configuration.EntitlementVerificationMode` (RevenueCat#2290) via NachoSoto (@NachoSoto) * SwiftUI: Paywall View should respond to changes on the UserView model (RevenueCat#2297) via ConfusedVorlon (@ConfusedVorlon) * Deprecate `usesStoreKit2IfAvailable` (RevenueCat#2293) via Andy Boedo (@aboedo) * `Signing`: updated to use production public key (RevenueCat#2274) via NachoSoto (@NachoSoto) </details> --------- Co-authored-by: RCGitBot <dev+RCGitBot@revenuecat.com>

NachoSoto added the refactor A code change that neither fixes a bug nor adds a feature label Mar 21, 2023

NachoSoto requested a review from a team March 21, 2023 19:28

NachoSoto commented Mar 21, 2023

View reviewed changes

NachoSoto changed the title ~~Offline Entitlements: create CustomerInfo from offline entitlements~~ [WIP] Offline Entitlements: create CustomerInfo from offline entitlements Mar 21, 2023

NachoSoto commented Mar 21, 2023

View reviewed changes

Tests/UnitTests/OfflineEntitlements/CustomerInfoOfflineEntitlementsTest.swift Outdated Show resolved Hide resolved

NachoSoto force-pushed the nacho/sdk-2987-compute-customerinfo-from-a-list-of branch 2 times, most recently from 6fee0a9 to f829bf1 Compare March 21, 2023 23:13

NachoSoto changed the base branch from andy/sdk-2978-write-code-to-list-purchases-made-by-the to main March 21, 2023 23:32

NachoSoto force-pushed the nacho/sdk-2987-compute-customerinfo-from-a-list-of branch 2 times, most recently from 92e756c to 2d16049 Compare March 21, 2023 23:53

NachoSoto changed the base branch from main to nacho/sdk-2981-use-new-endpoint-to-get-entitlements-2 March 22, 2023 00:00

NachoSoto changed the base branch from nacho/sdk-2981-use-new-endpoint-to-get-entitlements-2 to nacho/sdk-2981-use-new-endpoint-to-get-entitlements March 22, 2023 00:00

NachoSoto force-pushed the nacho/sdk-2987-compute-customerinfo-from-a-list-of branch 3 times, most recently from b53cbdb to 539c498 Compare March 22, 2023 00:26

NachoSoto mentioned this pull request Mar 22, 2023

Offline Entitlements: get SK2 purchase information #2352

Closed

Base automatically changed from nacho/sdk-2981-use-new-endpoint-to-get-entitlements to main March 22, 2023 00:36

NachoSoto force-pushed the nacho/sdk-2987-compute-customerinfo-from-a-list-of branch 2 times, most recently from 6003e23 to 3f21f98 Compare March 22, 2023 16:59

NachoSoto changed the base branch from main to nacho/sdk-2985-store-entitlements-products-mapping March 22, 2023 19:36

NachoSoto force-pushed the nacho/sdk-2987-compute-customerinfo-from-a-list-of branch from 3f21f98 to 8117ca1 Compare March 22, 2023 19:44

NachoSoto force-pushed the nacho/sdk-2985-store-entitlements-products-mapping branch from b4e1699 to 9f5a9f3 Compare March 22, 2023 19:48

NachoSoto force-pushed the nacho/sdk-2987-compute-customerinfo-from-a-list-of branch 3 times, most recently from 73cc403 to 74e67ee Compare March 22, 2023 23:12

NachoSoto changed the title ~~[WIP] Offline Entitlements: create CustomerInfo from offline entitlements~~ Offline Entitlements: create CustomerInfo from offline entitlements Mar 22, 2023

NachoSoto marked this pull request as ready for review March 22, 2023 23:13

vegaro reviewed Mar 22, 2023

View reviewed changes

Sources/OfflineEntitlements/CustomerInfo+OfflineEntitlements.swift Outdated Show resolved Hide resolved

NachoSoto requested a review from a team March 22, 2023 23:14

NachoSoto force-pushed the nacho/sdk-2985-store-entitlements-products-mapping branch from d285cf5 to 362f1e8 Compare March 23, 2023 16:09

NachoSoto commented Mar 23, 2023

View reviewed changes

NachoSoto force-pushed the nacho/sdk-2987-compute-customerinfo-from-a-list-of branch from cadce12 to c00cfdb Compare March 23, 2023 20:06

Base automatically changed from nacho/sdk-2985-store-entitlements-products-mapping to main March 23, 2023 20:30

aboedo and others added 7 commits March 23, 2023 15:37

[WIP] Create CustomerInfo from StoreKit.Transaction and `ProductE…

5f7a766

…ntitlementMappingResponse`

Finished tests

dfaadbb

Setting rawData

37c4388

Setting originalApplicationVersion

ce3c26c

Injecting user ID

089861c

Changed PurchasedProductsFetcher to class

8dd1506

Setting management URL

72033e0

NachoSoto force-pushed the nacho/sdk-2987-compute-customerinfo-from-a-list-of branch from 276d952 to 72033e0 Compare March 23, 2023 22:37

vegaro reviewed Mar 23, 2023

View reviewed changes

tonidero approved these changes Mar 24, 2023

View reviewed changes

Typo

39b0b5e

Co-authored-by: Toni Rico <antonio.rico.diez@revenuecat.com>

aboedo reviewed Mar 24, 2023

View reviewed changes

Sources/OfflineEntitlements/PurchasedSK2Product.swift Outdated Show resolved Hide resolved

NachoSoto added 3 commits March 24, 2023 08:31

PurchasedProductsFetcher tests

6d4d23b

Using real expiration date

db6f8d6

Disambiguate overlapping entitlements

a44cbff

NachoSoto enabled auto-merge (squash) March 24, 2023 17:33

NachoSoto merged commit 339e13d into main Mar 24, 2023

NachoSoto deleted the nacho/sdk-2987-compute-customerinfo-from-a-list-of branch March 24, 2023 17:41

NachoSoto mentioned this pull request Apr 10, 2023

Fix iOS 12 compilation #2394

Merged

RCGitBot mentioned this pull request May 3, 2023

[AUTOMATIC] Release/4.19.0 #2466

Closed

This was referenced May 12, 2023

Release/4.19 #2483

Closed

Release/4.19.0 #2491

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`Offline Entitlements`: create `CustomerInfo` from offline entitlements #2358

`Offline Entitlements`: create `CustomerInfo` from offline entitlements #2358

NachoSoto commented Mar 21, 2023 •

edited

NachoSoto Mar 21, 2023

NachoSoto Mar 23, 2023

NachoSoto commented Mar 23, 2023

codecov bot commented Mar 23, 2023 •

edited

vegaro Mar 23, 2023

NachoSoto Mar 24, 2023

tonidero left a comment

tonidero Mar 24, 2023

NachoSoto Mar 24, 2023

Offline Entitlements: create CustomerInfo from offline entitlements #2358

Offline Entitlements: create CustomerInfo from offline entitlements #2358

Conversation

NachoSoto commented Mar 21, 2023 • edited

NachoSoto Mar 21, 2023

Choose a reason for hiding this comment

NachoSoto Mar 23, 2023

Choose a reason for hiding this comment

NachoSoto commented Mar 23, 2023

codecov bot commented Mar 23, 2023 • edited

Codecov Report

vegaro Mar 23, 2023

Choose a reason for hiding this comment

NachoSoto Mar 24, 2023

Choose a reason for hiding this comment

tonidero left a comment

Choose a reason for hiding this comment

tonidero Mar 24, 2023

Choose a reason for hiding this comment

NachoSoto Mar 24, 2023

Choose a reason for hiding this comment

`Offline Entitlements`: create `CustomerInfo` from offline entitlements #2358

`Offline Entitlements`: create `CustomerInfo` from offline entitlements #2358

NachoSoto commented Mar 21, 2023 •

edited

codecov bot commented Mar 23, 2023 •

edited