Prevent a warning when compiling for Mac Catalyst #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described on https://developer.apple.com/documentation/storekit/skpaymenttransactionobserver/2877502-paymentqueue?language=objc , the method - (BOOL)paymentQueue:(SKPaymentQueue *)queue shouldAddStorePayment:(SKPayment *)payment forProduct:(SKProduct *)product is only available for iOS and tvOS but not for Mac Catalyst. However PURCHASES_INITIATED_FROM_APP_STORE_AVAILABLE was set to 1 for Mac Catalyst which led to a unavailable method warning: RevenueCat/purchases-ios/Purchases/Purchasing/RCStoreKitWrapper.m:87:1: warning: implementing unavailable method [-Wdeprecated-implementations] - (BOOL)paymentQueue:(SKPaymentQueue *)queue shouldAddStorePayment:(SKPayment *)payment forProduct:(SKProduct *)product ^ In module 'StoreKit' imported from RevenueCat/purchases-ios/Purchases/Purchasing/RCStoreKitWrapper.h:10: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/System/iOSSupport/System/Library/Frameworks/StoreKit.framework/Headers/SKPaymentQueue.h:99:1: note: method 'paymentQueue:shouldAddStorePayment:forProduct:' declared here - (BOOL)paymentQueue:(SKPaymentQueue *)queue shouldAddStorePayment:(SKPayment *)payment forProduct:(SKProduct *)product NS_SWIFT_NAME(paymentQueue(_:shouldAddStorePayment:for:)) API_AVAILABLE(ios(11.0)) API_UNAVAILABLE(macos, macCatalyst, watchos); The fix this warning, PURCHASES_INITIATED_FROM_APP_STORE_AVAILABLE is set to 0 when compiling for Mac Catalyst.
|
hi! thanks for opening! and nice catch 😎
it only is an issue for this line, the rest just happen to work, but I'll do a pass at cleaning this up as a follow-up PR. Merging this one. Thanks again @Timac for opening! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As described on https://developer.apple.com/documentation/storekit/skpaymenttransactionobserver/2877502-paymentqueue?language=objc , the method
- (BOOL)paymentQueue:(SKPaymentQueue *)queue shouldAddStorePayment:(SKPayment *)payment forProduct:(SKProduct *)productis only available for iOS and tvOS but not for Mac Catalyst.However
PURCHASES_INITIATED_FROM_APP_STORE_AVAILABLEis set to 1 for Mac Catalyst which leads to a unavailable method warning:Steps to reproduce
Result: You see the warning.
Proposed solution:
To fix this warning,
PURCHASES_INITIATED_FROM_APP_STORE_AVAILABLEis set to 0 when compiling for Mac Catalyst.