Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paywalls: fix template 4 layout bug on iOS 16 #3381

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Paywalls: fix template 4 layout bug on iOS 16 #3381

merged 2 commits into from
Nov 3, 2023

Commits on Nov 2, 2023

  1. Paywalls: fix template 4 layout bug on iOS 16 

    This only reproduces on iOS 16 + using the new `displayCloseButton: true` (because it embeds `PaywallView` in a `NavigationView`).

The problem was that the template used `ViewDimentionPreferenceKey` in several parts of the hierarchy and `SwiftUI` mixes both.
I work around it by separating `onWidthChange` and `onHeightChange`.
    @NachoSoto
    NachoSoto committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    40ee848 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Removed duplicate code

    @NachoSoto
    NachoSoto committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    70c8c34 View commit details
    Browse the repository at this point in the history