Paywalls: fix template 4 layout bug on iOS 16
#3381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only reproduces on iOS 16 + using the new `displayCloseButton: true` (because it embeds `PaywallView` in a `NavigationView`). The problem was that the template used `ViewDimentionPreferenceKey` in several parts of the hierarchy and `SwiftUI` mixes both. I work around it by separating `onWidthChange` and `onHeightChange`.
NachoSoto
force-pushed
the
paywalls-template-4-layout-fix
branch
from
536f6a8
to
40ee848
Compare
tonidero
approved these changes
Nov 3, 2023
|
|
||
| static var defaultValue: Value = 10 | ||
|
|
||
| static func reduce(value: inout Value, nextValue: () -> Value) { | ||
| static func reduce(value: inout CGFloat, nextValue: () -> CGFloat) { |
There was a problem hiding this comment.
Is it possible to move this static method to the protocol considering it's repeated between width and height?
This was referenced Nov 6, 2023
NachoSoto
pushed a commit
that referenced
this pull request
Nov 7, 2023
**This is an automatic release.** ### RevenueCatUI * `Paywalls`: fix Turkish discount string (#3385) via NachoSoto (@NachoSoto) * `Paywalls`: fix template 4 layout bug on iOS 16 (#3381) via NachoSoto (@NachoSoto) ### Dependency Updates * Bump fastlane-plugin-revenuecat_internal from `a297205` to `0ddee10` (#3383) via dependabot[bot] (@dependabot[bot]) ### Other Changes * `CircleCI`: fix `visionOS` job (#3384) via NachoSoto (@NachoSoto)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only reproduces on iOS 16 and using the new
displayCloseButton: true(because it embedsPaywallViewin aNavigationView).The problem was that the template used
ViewDimentionPreferenceKeyin several parts of the hierarchy andSwiftUImixes both.I work around it by separating
onWidthChangeandonHeightChange.