Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.debugRevenueCatOverlay: added Locale #3539

Merged
merged 4 commits into from
Dec 21, 2023
Merged

.debugRevenueCatOverlay: added Locale #3539

merged 4 commits into from
Dec 21, 2023

Conversation

NachoSoto
Copy link
Contributor

This adds the Locale.identifier and the currency code.
It can help debug issues with paywalls, currencies, localization, etc.

Simulator Screenshot - iPhone 15 Pro Max - 2023-12-21 at 11 05 36

This adds the `Locale.identifier` and the currency code.
It can help debug issues with paywalls, currencies, localization, etc.
@NachoSoto NachoSoto added the refactor A code change that neither fixes a bug nor adds a feature label Dec 21, 2023
@NachoSoto NachoSoto requested a review from a team December 21, 2023 19:07
@@ -78,7 +78,7 @@ struct OfferingsList: View {
Text(error.description)

case .none:
ProgressView()
SwiftUI.ProgressView()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't compiling after #3526. I figured I'd fix it here instead of making another PR for one line.

Copy link
Contributor

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@NachoSoto NachoSoto enabled auto-merge (squash) December 21, 2023 20:15
@NachoSoto NachoSoto merged commit 67b421e into main Dec 21, 2023
19 of 20 checks passed
@NachoSoto NachoSoto deleted the debug-view-locale branch December 21, 2023 20:19
This was referenced Dec 21, 2023
NachoSoto pushed a commit that referenced this pull request Dec 22, 2023
**This is an automatic release.**

### RevenueCatUI
* `Paywalls`: add header image to `watchOS` paywalls (#3542) via
NachoSoto (@NachoSoto)
* `Paywalls`: improve template 5 landscape layout (#3534) via NachoSoto
(@NachoSoto)
* `Paywalls`: fix template 5 footer loading view alignment (#3537) via
NachoSoto (@NachoSoto)
* `Paywalls`: improve template 1 landscape layout (#3532) via NachoSoto
(@NachoSoto)
* `Paywalls`: fix `ColorInformation.multiScheme` on `watchOS` (#3530)
via NachoSoto (@NachoSoto)
### Other Changes
* `Trusted Entitlements`: tests for signature verification without
header hash (#3505) via NachoSoto (@NachoSoto)
* `.debugRevenueCatOverlay`: added `Locale` (#3539) via NachoSoto
(@NachoSoto)
* `Trusted Entitlements`: add support for signing request headers
(#3424) via NachoSoto (@NachoSoto)
* `CI`: Add architecture to cache keys (#3538) via Mark Villacampa
(@MarkVillacampa)
* `Paywalls Tester`: remove double close button (#3531) via NachoSoto
(@NachoSoto)
* Fix `RevenueCatUI` snapshot tests (#3526) via NachoSoto (@NachoSoto)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants