StoreProduct: add localized price per period strings
#3546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboedo
force-pushed
the
andy/add_price_per_period_string
branch
from
723aa73
to
884b54e
Compare
nvmd, those aren't equivalent since they're not string |
aboedo
force-pushed
the
andy/add_price_per_period_string
branch
from
ab57c5d
to
f1533d3
Compare
NachoSoto
approved these changes
Jan 8, 2024
| @@ -442,6 +442,15 @@ class StoreProductTests: StoreKitConfigTestCase { | |||
| self.logger.verifyMessageWasLogged(Strings.storeKit.sk1_no_known_product_type, level: .debug) | |||
| } | |||
|
|
|||
| func testPricePerPeriod() async throws { | |||
NachoSoto
changed the title
StoreProduct: add localized price per period strings
…ePerYear formatted variants
NachoSoto
force-pushed
the
andy/add_price_per_period_string
branch
from
f1533d3
to
2ccd6f3
Compare
|
|
@aboedo oh I just noticed you mentioned that! Yeah I removed that code now that it's implemented in |
NachoSoto
pushed a commit
that referenced
this pull request
Jan 17, 2024
**This is an automatic release.** ### New Features * `StoreProduct`: add localized price per period strings (#3546) via Andy Boedo (@aboedo) ### RevenueCatUI * `Paywalls`: new `.onPurchaseCancelled` and `paywallViewControllerDidCancelPurchase:` (#3578) via NachoSoto (@NachoSoto) * `Paywalls`: improve error display (#3577) via NachoSoto (@NachoSoto) ### Dependency Updates * Bump fastlane-plugin-revenuecat_internal from `0ddee10` to `e6ba247` (#3575) via dependabot[bot] (@dependabot[bot]) ### Other Changes * `PurchaseTester`: improved `ReceiptInspector` so it accepts receipts with escape sequences (#3554) via Andy Boedo (@aboedo)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
localizedPricePerWeek,localizedPricePerMonthandlocalizedPricePerYear.I started on this before noticing that we already have an equivalent at the package level, still need to unify them.